Reland of Removes usage of native base::android::GetApplicationContext()

Reland of Removes usage of native base::android::GetApplicationContext()

The change is now compatible with the old JVM::Initialize API. The
context is passed to the ContextUtils class when calling its deprecated
signature.

BUG=webrtc:7665
NOTRY=True # Only comment changes since the last patchset.

Review-Url: https://codereview.webrtc.org/2903253004
Cr-Commit-Position: refs/heads/master@{#18268}
Committed: https://chromium.googlesource.com/external/webrtc/+/d7fdb8014d71e669618c675b2c29c6dfe7d426d3

[sakal, 2017-05-26 07:41:10]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 07:41:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[sakal, 2017-05-26 07:41:36]

sakal@webrtc.org changed reviewers:
+ henrika@webrtc.org, magjed@webrtc.org

[sakal, 2017-05-26 07:41:37]

PTAL

[kjellander_webrtc, 2017-05-26 08:11:43]

kjellander@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[kjellander_webrtc, 2017-05-26 08:11:43]

Please update the description about that this time it's compatible with the old
API (it is, right?)

And run trybots.

[sakal, 2017-05-26 08:18:41]

Description was changed from

==========
Reland of Removes usage of native base::android::GetApplicationContext()

BUG=webrtc:7665
==========

to

==========
Reland of Removes usage of native base::android::GetApplicationContext()

The change is now compatible with the old JVM::Initialize API. The context is
passed to the ContextUtils class when calling its deprecated signature.

BUG=webrtc:7665
==========

[sakal, 2017-05-26 08:18:55]

Description was changed from

==========
Reland of Removes usage of native base::android::GetApplicationContext()

The change is now compatible with the old JVM::Initialize API. The context is
passed to the ContextUtils class when calling its deprecated signature.

BUG=webrtc:7665
==========

to

==========
Reland of Removes usage of native base::android::GetApplicationContext()

The change is now compatible with the old JVM::Initialize API. The
context is passed to the ContextUtils class when calling its deprecated
signature.

BUG=webrtc:7665
==========

[sakal, 2017-05-26 08:19:43]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 08:19:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[sakal, 2017-05-26 08:20:23]

The CQ bit was unchecked by sakal@webrtc.org

[henrika_webrtc, 2017-05-26 08:34:47]

lgtm

[henrika_webrtc, 2017-05-26 08:34:57]

https://codereview.webrtc.org/2903253004/diff/60001/webrtc/modules/utility/in...
File webrtc/modules/utility/include/jvm_android.h (right):

https://codereview.webrtc.org/2903253004/diff/60001/webrtc/modules/utility/in...
webrtc/modules/utility/include/jvm_android.h:151: // Deprecated old signature
with Android context.
Nit, deprecate.

[sakal, 2017-05-26 08:49:20]

Description was changed from

==========
Reland of Removes usage of native base::android::GetApplicationContext()

The change is now compatible with the old JVM::Initialize API. The
context is passed to the ContextUtils class when calling its deprecated
signature.

BUG=webrtc:7665
==========

to

==========
Reland of Removes usage of native base::android::GetApplicationContext()

The change is now compatible with the old JVM::Initialize API. The
context is passed to the ContextUtils class when calling its deprecated
signature.

BUG=webrtc:7665
NOTRY=True # Only comment changes since the last patchset.
==========

[sakal, 2017-05-26 08:49:33]

https://codereview.webrtc.org/2903253004/diff/60001/webrtc/modules/utility/in...
File webrtc/modules/utility/include/jvm_android.h (right):

https://codereview.webrtc.org/2903253004/diff/60001/webrtc/modules/utility/in...
webrtc/modules/utility/include/jvm_android.h:151: // Deprecated old signature
with Android context.
On 2017/05/26 08:34:56, henrika_webrtc wrote:
> Nit, deprecate.

Done.

[sakal, 2017-05-26 08:49:49]

The CQ bit was checked by sakal@webrtc.org

[sakal, 2017-05-26 08:49:49]

The patchset sent to the CQ was uploaded after l-g-t-m from henrika@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2903253004/#ps80001 (title:
"Deprecated comment.")

[commit-bot: I haz the power, 2017-05-26 08:49:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-26 08:51:54]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495788589279890,
"parent_rev": "13ae11a4184c9e1b8d3d68203d0e60365d49b403", "commit_rev":
"d7fdb8014d71e669618c675b2c29c6dfe7d426d3"}

[commit-bot: I haz the power, 2017-05-26 08:51:59]

Description was changed from

==========
Reland of Removes usage of native base::android::GetApplicationContext()

The change is now compatible with the old JVM::Initialize API. The
context is passed to the ContextUtils class when calling its deprecated
signature.

BUG=webrtc:7665
NOTRY=True # Only comment changes since the last patchset.
==========

to

==========
Reland of Removes usage of native base::android::GetApplicationContext()

The change is now compatible with the old JVM::Initialize API. The
context is passed to the ContextUtils class when calling its deprecated
signature.

BUG=webrtc:7665
NOTRY=True # Only comment changes since the last patchset.

Review-Url: https://codereview.webrtc.org/2903253004
Cr-Commit-Position: refs/heads/master@{#18268}
Committed:
https://chromium.googlesource.com/external/webrtc/+/d7fdb8014d71e669618c675b2...
==========

[commit-bot: I haz the power, 2017-05-26 08:52:00]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/d7fdb8014d71e669618c675b2...

[kjellander_webrtc, 2017-05-26 08:59:07]

lgtm