Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 2902743002: Cast sequence number in RtpFrameObject. (Closed)

Created:
3 years, 7 months ago by philipel
Modified:
3 years, 7 months ago
Reviewers:
holmer, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Cast sequence number in RtpFrameObject. BUG=webrtc:7700 Review-Url: https://codereview.webrtc.org/2902743002 Cr-Commit-Position: refs/heads/master@{#18237} Committed: https://chromium.googlesource.com/external/webrtc/+/7d79e63a484c89b2329a51ca4c83a42ce2d8ff96

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M webrtc/modules/video_coding/frame_object.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/video_packet_buffer_unittest.cc View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
philipel
Missed a cast in the loop condition :(
3 years, 7 months ago (2017-05-23 14:18:26 UTC) #2
holmer
lgtm
3 years, 7 months ago (2017-05-23 14:36:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2902743002/1
3 years, 7 months ago (2017-05-23 14:43:05 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-23 14:43:07 UTC) #8
stefan-webrtc
lgtm
3 years, 7 months ago (2017-05-23 14:44:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2902743002/1
3 years, 7 months ago (2017-05-23 14:44:24 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 15:19:16 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/7d79e63a484c89b2329a51ca4...

Powered by Google App Engine
This is Rietveld 408576698