Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2902723002: Preserve level controller output when no other effects are active (Closed)

Created:
3 years, 7 months ago by peah-webrtc
Modified:
3 years, 7 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Preserve level controller output when no other effects are active This CL ensures that the output of the level controller is kept when no other submodules in APM are active BUG=webrtc:7697 , Review-Url: https://codereview.webrtc.org/2902723002 Cr-Commit-Position: refs/heads/master@{#18230} Committed: https://chromium.googlesource.com/external/webrtc/+/23ac8b49f4f8f5cbf709ddefcb2c721bab2505de

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M webrtc/modules/audio_processing/audio_processing_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
peah-webrtc
Hi, Could you please take a look at this CL?
3 years, 7 months ago (2017-05-23 11:37:50 UTC) #6
ivoc
lgtm.
3 years, 7 months ago (2017-05-23 12:06:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2902723002/20001
3 years, 7 months ago (2017-05-23 12:07:21 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 12:34:02 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/23ac8b49f4f8f5cbf709ddefc...

Powered by Google App Engine
This is Rietveld 408576698