Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2902213002: Support "UDP/DTLS/SCTP" and "TCP/DTLS/SCTP" profile strings. (Closed)

Created:
3 years, 7 months ago by Taylor Brandstetter
Modified:
3 years, 7 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Support "UDP/DTLS/SCTP" and "TCP/DTLS/SCTP" profile strings. This CL doesn't yet offer these protos; it just accepts them if they're seen in a remote offer. It also doesn't verify that the ICE candidate protocol matches the m= section protocol (UDP vs. TCP), since we don't do this elsewhere and don't really have a reason to care. This CL also adds an integration test that receives a spec-compliant SCTP offer and attempts to send data bidirectionally. BUG=webrtc:7706 Review-Url: https://codereview.webrtc.org/2902213002 Cr-Commit-Position: refs/heads/master@{#18265} Committed: https://chromium.googlesource.com/external/webrtc/+/8b7e9ad55442cd6f5854d7de65408dc8095356b2

Patch Set 1 #

Total comments: 1

Patch Set 2 : Finish TODO comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -28 lines) Patch
M webrtc/pc/mediasession.cc View 1 6 chunks +36 lines, -28 lines 0 comments Download
M webrtc/pc/mediasession_unittest.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M webrtc/pc/peerconnection_integrationtest.cc View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Taylor Brandstetter
PTAL https://codereview.webrtc.org/2902213002/diff/1/webrtc/pc/mediasession.cc File webrtc/pc/mediasession.cc (right): https://codereview.webrtc.org/2902213002/diff/1/webrtc/pc/mediasession.cc#newcode89 webrtc/pc/mediasession.cc:89: protocol == kMediaProtocolTcpDtlsSctp; This is the only method ...
3 years, 7 months ago (2017-05-24 17:43:21 UTC) #3
pthatcher1
lgtm
3 years, 7 months ago (2017-05-25 04:51:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2902213002/20001
3 years, 7 months ago (2017-05-25 16:17:43 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 16:39:01 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/8b7e9ad55442cd6f5854d7de6...

Powered by Google App Engine
This is Rietveld 408576698