Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 2900713002: Increase number of unsignaled audio streams we handle to 4. (Closed)

Created:
3 years, 7 months ago by the sun
Modified:
3 years, 6 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Increase number of unsignaled audio streams we handle to 4. BUG=webrtc:7179 b/34746131 Review-Url: https://codereview.webrtc.org/2900713002 Cr-Commit-Position: refs/heads/master@{#18551} Committed: https://chromium.googlesource.com/external/webrtc/+/418b7d34d18a198541156c80084c9f8e9499ba39

Patch Set 1 #

Patch Set 2 : Fix unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/media/engine/webrtcvoiceengine.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/engine/webrtcvoiceengine_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
the sun
3 years, 7 months ago (2017-05-22 11:48:54 UTC) #2
hlundin-webrtc
You've got some tests to fix, but with that done, you have my lgtm.
3 years, 7 months ago (2017-05-22 13:31:38 UTC) #3
the sun
On 2017/05/22 13:31:38, hlundin-webrtc wrote: > You've got some tests to fix, but with that ...
3 years, 7 months ago (2017-05-23 21:16:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2900713002/20001
3 years, 6 months ago (2017-06-13 07:12:56 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 07:38:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/418b7d34d18a198541156c800...

Powered by Google App Engine
This is Rietveld 408576698