Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: net/nqe/network_quality_estimator_unittest.cc

Issue 2899453002: Pass parsed network quality estimator params when constructing NQE (Closed)
Patch Set: Rebased Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/nqe/network_quality_estimator_test_util.cc ('k') | net/nqe/throughput_analyzer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/nqe/network_quality_estimator_unittest.cc
diff --git a/net/nqe/network_quality_estimator_unittest.cc b/net/nqe/network_quality_estimator_unittest.cc
index 29e12aa30440bd8c149a2c65adc8b77ebfe123d9..dfa866a5cf36c1195703bc36d3d0be4a3fa69f82 100644
--- a/net/nqe/network_quality_estimator_unittest.cc
+++ b/net/nqe/network_quality_estimator_unittest.cc
@@ -2842,12 +2842,12 @@ TEST(NetworkQualityEstimatorTest,
EXPECT_EQ(nqe::internal::kInvalidThroughput,
rtt_throughput_observer.downstream_throughput_kbps());
} else {
- EXPECT_EQ(estimator.params_.TypicalNetworkQuality(ect_type).http_rtt(),
+ EXPECT_EQ(estimator.params_->TypicalNetworkQuality(ect_type).http_rtt(),
rtt_throughput_observer.http_rtt());
EXPECT_EQ(
- estimator.params_.TypicalNetworkQuality(ect_type).transport_rtt(),
+ estimator.params_->TypicalNetworkQuality(ect_type).transport_rtt(),
rtt_throughput_observer.transport_rtt());
- EXPECT_EQ(estimator.params_.TypicalNetworkQuality(ect_type)
+ EXPECT_EQ(estimator.params_->TypicalNetworkQuality(ect_type)
.downstream_throughput_kbps(),
rtt_throughput_observer.downstream_throughput_kbps());
}
@@ -2888,12 +2888,12 @@ TEST(NetworkQualityEstimatorTest, TypicalNetworkQualities) {
// computed as |effective_connection_type|.
estimator.set_start_time_null_http_rtt(
estimator.params_
- .TypicalNetworkQuality(static_cast<EffectiveConnectionType>(
+ ->TypicalNetworkQuality(static_cast<EffectiveConnectionType>(
effective_connection_type))
.http_rtt());
estimator.set_start_time_null_transport_rtt(
estimator.params_
- .TypicalNetworkQuality(static_cast<EffectiveConnectionType>(
+ ->TypicalNetworkQuality(static_cast<EffectiveConnectionType>(
effective_connection_type))
.transport_rtt());
estimator.set_start_time_null_downlink_throughput_kbps(INT32_MAX);
« no previous file with comments | « net/nqe/network_quality_estimator_test_util.cc ('k') | net/nqe/throughput_analyzer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698