Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: net/nqe/network_quality_estimator_test_util.cc

Issue 2899453002: Pass parsed network quality estimator params when constructing NQE (Closed)
Patch Set: Rebased Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/nqe/network_quality_estimator_params.cc ('k') | net/nqe/network_quality_estimator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/nqe/network_quality_estimator_test_util.cc
diff --git a/net/nqe/network_quality_estimator_test_util.cc b/net/nqe/network_quality_estimator_test_util.cc
index 051b68107d89ef637a3fed46be2b7263493bc1fe..81372b4892cd44ff95c337f9fb0c376c4c03e2e3 100644
--- a/net/nqe/network_quality_estimator_test_util.cc
+++ b/net/nqe/network_quality_estimator_test_util.cc
@@ -10,6 +10,7 @@
#include "net/base/load_flags.h"
#include "net/log/net_log_with_source.h"
#include "net/log/test_net_log_entry.h"
+#include "net/nqe/network_quality_estimator_params.h"
#include "net/test/embedded_test_server/http_response.h"
#include "net/traffic_annotation/network_traffic_annotation_test_helper.h"
#include "net/url_request/url_request.h"
@@ -66,12 +67,14 @@ TestNetworkQualityEstimator::TestNetworkQualityEstimator(
bool add_default_platform_observations,
bool suppress_notifications_for_testing,
std::unique_ptr<BoundTestNetLog> net_log)
- : NetworkQualityEstimator(std::move(external_estimate_provider),
- variation_params,
- allow_local_host_requests_for_tests,
- allow_smaller_responses_for_tests,
- add_default_platform_observations,
- net_log->bound()),
+ : NetworkQualityEstimator(
+ std::move(external_estimate_provider),
+ base::MakeUnique<NetworkQualityEstimatorParams>(variation_params),
+ allow_local_host_requests_for_tests,
+ allow_smaller_responses_for_tests,
+ add_default_platform_observations,
+ net_log->bound()),
+
current_network_type_(NetworkChangeNotifier::CONNECTION_UNKNOWN),
accuracy_recording_intervals_set_(false),
rand_double_(0.0),
« no previous file with comments | « net/nqe/network_quality_estimator_params.cc ('k') | net/nqe/network_quality_estimator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698