Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2899313004: Use overloaded UpdateNetworkMetrics() (Closed)

Created:
3 years, 7 months ago by eladalon
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use overloaded UpdateNetworkMetrics() Use an overloaded version of UpdateNetworkMetrics() which does not require us to explicitly pass in an rtc::Optional. BUG=None Review-Url: https://codereview.webrtc.org/2899313004 Cr-Commit-Position: refs/heads/master@{#18347} Committed: https://chromium.googlesource.com/external/webrtc/+/108904cba164afe3cf62dcb166f44b9ffb82eabb

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -132 lines) Patch
M webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_plr_based_unittest.cc View 1 2 3 4 5 11 chunks +40 lines, -59 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_rplr_based_unittest.cc View 1 2 3 4 5 15 chunks +42 lines, -73 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
eladalon
Like with the CL on which this CL is based, I'll add the PLR-based-FEC-controller equivalent ...
3 years, 7 months ago (2017-05-25 13:53:36 UTC) #2
minyue-webrtc
lgtm
3 years, 7 months ago (2017-05-26 06:33:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2899313004/100001
3 years, 6 months ago (2017-05-31 09:19:52 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 09:46:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/108904cba164afe3cf62dcb16...

Powered by Google App Engine
This is Rietveld 408576698