Correct sequence-number injection into packets in rtp_packet_unittest.cc

Correct sequence-number injection into packets in rtp_packet_unittest.cc

BUG=None

Review-Url: https://codereview.webrtc.org/2899293002
Cr-Commit-Position: refs/heads/master@{#18257}
Committed: https://chromium.googlesource.com/external/webrtc/+/ae550e397a54a3b0efcf9f4dbaa953445ab787cf

[eladalon, 2017-05-24 14:44:45]

Description was changed from

==========
Correct sequence-number injection into packets in rtp_packet_unittest.cc

BUG=
==========

to

==========
Correct sequence-number injection into packets in rtp_packet_unittest.cc

BUG=None
==========

[eladalon, 2017-05-24 14:44:45]

eladalon@webrtc.org changed reviewers:
+ stefan@webrtc.org

[eladalon, 2017-05-24 14:45:07]

PTAL

[danilchap, 2017-05-24 14:52:16]

danilchap@webrtc.org changed reviewers:
+ danilchap@webrtc.org

[danilchap, 2017-05-24 14:52:17]

lgtm
Thank you, testing parsing of the high byte of sequence number was missing.

https://codereview.webrtc.org/2899293002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtp_packet_unittest.cc (right):

https://codereview.webrtc.org/2899293002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtp_packet_unittest.cc:28: constexpr uint8_t
kSeqNumFirstHalf = kSeqNum >> 8;
may be ...FirstByte

[eladalon, 2017-05-24 15:09:17]

https://codereview.webrtc.org/2899293002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtp_packet_unittest.cc (right):

https://codereview.webrtc.org/2899293002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtp_packet_unittest.cc:28: constexpr uint8_t
kSeqNumFirstHalf = kSeqNum >> 8;
On 2017/05/24 14:52:16, danilchap wrote:
> may be ...FirstByte

Done.

[eladalon, 2017-05-24 15:09:55]

The CQ bit was checked by eladalon@webrtc.org

[eladalon, 2017-05-24 15:09:56]

The patchset sent to the CQ was uploaded after l-g-t-m from danilchap@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2899293002/#ps20001 (title:
"CR response")

[commit-bot: I haz the power, 2017-05-24 15:10:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-24 15:28:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495638595643450,
"parent_rev": "b30cb6bc3345bd12f641a8ffebbb4c8ee978c80a", "commit_rev":
"ae550e397a54a3b0efcf9f4dbaa953445ab787cf"}

[commit-bot: I haz the power, 2017-05-24 15:28:17]

Description was changed from

==========
Correct sequence-number injection into packets in rtp_packet_unittest.cc

BUG=None
==========

to

==========
Correct sequence-number injection into packets in rtp_packet_unittest.cc

BUG=None

Review-Url: https://codereview.webrtc.org/2899293002
Cr-Commit-Position: refs/heads/master@{#18257}
Committed:
https://chromium.googlesource.com/external/webrtc/+/ae550e397a54a3b0efcf9f4db...
==========

[commit-bot: I haz the power, 2017-05-24 15:28:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/ae550e397a54a3b0efcf9f4db...