More gracefully handle timing errors, such as unexpected changes in the rtp timestamp.

More gracefully handle timing errors, such as unexpected changes in the rtp timestamp.

BUG=webrtc:7682
Review-Url: https://codereview.webrtc.org/2898763005
Cr-Commit-Position: refs/heads/master@{#18245}
Committed: https://chromium.googlesource.com/external/webrtc/+/95e9754e4055ba0190a71dc4c0549182ae362dd4

[stefan-webrtc, 2017-05-23 07:06:09]

stefan@webrtc.org changed reviewers:
+ philipel@webrtc.org

[stefan-webrtc, 2017-05-23 07:06:09]

WDYT about adding this back? The old jitter buffer had this, and I think it
might be useful given that different cameras may produce issues like these if
restarted etc.

[philipel, 2017-05-23 10:32:44]

https://codereview.webrtc.org/2898763005/diff/1/webrtc/modules/video_coding/f...
File webrtc/modules/video_coding/frame_buffer2.cc (right):

https://codereview.webrtc.org/2898763005/diff/1/webrtc/modules/video_coding/f...
webrtc/modules/video_coding/frame_buffer2.cc:149: }
Nit: add newline after 149 :)

https://codereview.webrtc.org/2898763005/diff/1/webrtc/modules/video_coding/f...
webrtc/modules/video_coding/frame_buffer2.cc:199: bool timing_error = false;
Remove |timing_error| and just "return true" instead.

https://codereview.webrtc.org/2898763005/diff/1/webrtc/modules/video_coding/f...
webrtc/modules/video_coding/frame_buffer2.cc:210: << "). Resetting the video
jitter buffer.";
Remove "Resetting the video jitter buffer." from the warning messages.

[stefan-webrtc, 2017-05-23 15:20:02]

Comments addressed.

[stefan-webrtc, 2017-05-23 15:21:47]

https://codereview.webrtc.org/2898763005/diff/1/webrtc/modules/video_coding/f...
File webrtc/modules/video_coding/frame_buffer2.cc (right):

https://codereview.webrtc.org/2898763005/diff/1/webrtc/modules/video_coding/f...
webrtc/modules/video_coding/frame_buffer2.cc:149: }
On 2017/05/23 10:32:44, philipel wrote:
> Nit: add newline after 149 :)

Done.

https://codereview.webrtc.org/2898763005/diff/1/webrtc/modules/video_coding/f...
webrtc/modules/video_coding/frame_buffer2.cc:199: bool timing_error = false;
On 2017/05/23 10:32:44, philipel wrote:
> Remove |timing_error| and just "return true" instead.

Done.

https://codereview.webrtc.org/2898763005/diff/1/webrtc/modules/video_coding/f...
webrtc/modules/video_coding/frame_buffer2.cc:210: << "). Resetting the video
jitter buffer.";
On 2017/05/23 10:32:44, philipel wrote:
> Remove "Resetting the video jitter buffer." from the warning messages.

Done.

[philipel, 2017-05-23 16:11:48]

lgtm % comments

https://codereview.webrtc.org/2898763005/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/frame_buffer2.cc (right):

https://codereview.webrtc.org/2898763005/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/frame_buffer2.cc:205: } else if
(std::abs(render_time_ms - now_ms) > kMaxVideoDelayMs) {
Now we don't need the "else if" any more :)

https://codereview.webrtc.org/2898763005/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/frame_buffer2.cc:212: } else if
(static_cast<int>(timing_->TargetVideoDelay()) > kMaxVideoDelayMs) {
same here

[stefan-webrtc, 2017-05-23 16:33:43]

https://codereview.webrtc.org/2898763005/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/frame_buffer2.cc (right):

https://codereview.webrtc.org/2898763005/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/frame_buffer2.cc:205: } else if
(std::abs(render_time_ms - now_ms) > kMaxVideoDelayMs) {
On 2017/05/23 16:11:48, philipel wrote:
> Now we don't need the "else if" any more :)

Done.

https://codereview.webrtc.org/2898763005/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/frame_buffer2.cc:212: } else if
(static_cast<int>(timing_->TargetVideoDelay()) > kMaxVideoDelayMs) {
On 2017/05/23 16:11:48, philipel wrote:
> same here

Done.

[stefan-webrtc, 2017-05-23 16:34:40]

The CQ bit was checked by stefan@webrtc.org

[stefan-webrtc, 2017-05-23 16:34:41]

The patchset sent to the CQ was uploaded after l-g-t-m from philipel@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2898763005/#ps40001 (title:
".")

[commit-bot: I haz the power, 2017-05-23 16:34:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-23 16:52:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495557280753120,
"parent_rev": "7a3006bae7f1c61371581ddfa320524041119f20", "commit_rev":
"95e9754e4055ba0190a71dc4c0549182ae362dd4"}

[commit-bot: I haz the power, 2017-05-23 16:52:23]

Description was changed from

==========
More gracefully handle timing errors, such as unexpected changes in the rtp
timestamp.

BUG=webrtc:7682
==========

to

==========
More gracefully handle timing errors, such as unexpected changes in the rtp
timestamp.

BUG=webrtc:7682

Review-Url: https://codereview.webrtc.org/2898763005
Cr-Commit-Position: refs/heads/master@{#18245}
Committed:
https://chromium.googlesource.com/external/webrtc/+/95e9754e4055ba0190a71dc4c...
==========

[commit-bot: I haz the power, 2017-05-23 16:52:24]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/95e9754e4055ba0190a71dc4c...