Disabling flaky complexity tests for the audio processing module.

Disabling flaky complexity tests for the audio processing module.

The complexity test for the audio processing module have long proven
to give false alarms of complexity regressions for which no related
changes can be identified. Attempts to address that has improved the
that, but the tests do still give false alarms.

This CL deactivates the complexity tests until a better way of
testing this is available.

BUG=chromium:713507, webrtc:5846, webrtc:6685, webrtc:7712
Review-Url: https://codereview.webrtc.org/2897403006
Cr-Commit-Position: refs/heads/master@{#18879}
Committed: https://chromium.googlesource.com/external/webrtc/+/4235d78b574aa2923b2e01a9ab35873544b33dfe

[peah-webrtc, 2017-05-26 10:26:47]

peah@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[peah-webrtc, 2017-05-26 11:20:12]

Description was changed from

==========
Disabling flaky complexity tests for the audio processing module.

The complexity test for the audio processing module have long proven
to give false alarms of complexity regressions for which no related
changes can be identified. Attempts to address that has improved the
that, but the tests do still give false alarms.

This CL deactivates the complexity tests until a better way of
testing this is available.

BUG=chromium:713507, webrtc:5846,webrtc:6685
==========

to

==========
Disabling flaky complexity tests for the audio processing module.

The complexity test for the audio processing module have long proven
to give false alarms of complexity regressions for which no related
changes can be identified. Attempts to address that has improved the
that, but the tests do still give false alarms.

This CL deactivates the complexity tests until a better way of
testing this is available.

BUG=chromium:713507, webrtc:5846,webrtc:6685,webrtc:7712
==========

[hlundin-webrtc, 2017-05-29 12:57:25]

LGTM with comments addressed. Also, read the CL description again.

https://codereview.webrtc.org/2897403006/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/audio_processing_performance_unittest.cc
(right):

https://codereview.webrtc.org/2897403006/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_performance_unittest.cc:717:
TEST_P(CallSimulator, DISABLED_ApiCallDurationTest) {
Please, add a comment with reference to issue 7712.

https://codereview.webrtc.org/2897403006/diff/1/webrtc/modules/audio_processi...
File
webrtc/modules/audio_processing/level_controller/level_controller_complexity_unittest.cc
(right):

https://codereview.webrtc.org/2897403006/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/level_controller/level_controller_complexity_unittest.cc:190:
TEST(LevelControllerPerformanceTest, DISABLED_StandaloneProcessing) {
Please, add a comment with reference to issue 7712.

https://codereview.webrtc.org/2897403006/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/level_controller/level_controller_complexity_unittest.cc:223:
TEST(LevelControllerPerformanceTest, DISABLED_ProcessingViaApm) {
Please, add a comment with reference to issue 7712.

https://codereview.webrtc.org/2897403006/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/level_controller/level_controller_complexity_unittest.cc:232:
TEST(LevelControllerPerformanceTest, DISABLED_InteractionWithDefaultApm) {
Please, add a comment with reference to issue 7712.

[peah-webrtc, 2017-07-03 15:48:34]

https://codereview.webrtc.org/2897403006/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/audio_processing_performance_unittest.cc
(right):

https://codereview.webrtc.org/2897403006/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_performance_unittest.cc:717:
TEST_P(CallSimulator, DISABLED_ApiCallDurationTest) {
On 2017/05/29 12:57:25, hlundin-webrtc (OOOtoJul3) wrote:
> Please, add a comment with reference to issue 7712.

Done.

https://codereview.webrtc.org/2897403006/diff/1/webrtc/modules/audio_processi...
File
webrtc/modules/audio_processing/level_controller/level_controller_complexity_unittest.cc
(right):

https://codereview.webrtc.org/2897403006/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/level_controller/level_controller_complexity_unittest.cc:190:
TEST(LevelControllerPerformanceTest, DISABLED_StandaloneProcessing) {
On 2017/05/29 12:57:25, hlundin-webrtc (OOOtoJul3) wrote:
> Please, add a comment with reference to issue 7712.

Done.

https://codereview.webrtc.org/2897403006/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/level_controller/level_controller_complexity_unittest.cc:223:
TEST(LevelControllerPerformanceTest, DISABLED_ProcessingViaApm) {
On 2017/05/29 12:57:25, hlundin-webrtc (OOOtoJul3) wrote:
> Please, add a comment with reference to issue 7712.

Done.

https://codereview.webrtc.org/2897403006/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/level_controller/level_controller_complexity_unittest.cc:232:
TEST(LevelControllerPerformanceTest, DISABLED_InteractionWithDefaultApm) {
On 2017/05/29 12:57:25, hlundin-webrtc (OOOtoJul3) wrote:
> Please, add a comment with reference to issue 7712.

Done.

[peah-webrtc, 2017-07-03 15:49:19]

The CQ bit was checked by peah@webrtc.org

[peah-webrtc, 2017-07-03 15:49:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2897403006/#ps20001 (title:
"Changes in response to reviewer comments")

[commit-bot: I haz the power, 2017-07-03 15:49:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-03 16:11:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499096959966490,
"parent_rev": "7ab7fd66c44d8001899bb75de5aebb1b6e326b94", "commit_rev":
"4235d78b574aa2923b2e01a9ab35873544b33dfe"}

[commit-bot: I haz the power, 2017-07-03 16:11:31]

Description was changed from

==========
Disabling flaky complexity tests for the audio processing module.

The complexity test for the audio processing module have long proven
to give false alarms of complexity regressions for which no related
changes can be identified. Attempts to address that has improved the
that, but the tests do still give false alarms.

This CL deactivates the complexity tests until a better way of
testing this is available.

BUG=chromium:713507, webrtc:5846,webrtc:6685,webrtc:7712
==========

to

==========
Disabling flaky complexity tests for the audio processing module.

The complexity test for the audio processing module have long proven
to give false alarms of complexity regressions for which no related
changes can be identified. Attempts to address that has improved the
that, but the tests do still give false alarms.

This CL deactivates the complexity tests until a better way of
testing this is available.

BUG=chromium:713507, webrtc:5846,webrtc:6685,webrtc:7712

Review-Url: https://codereview.webrtc.org/2897403006
Cr-Commit-Position: refs/heads/master@{#18879}
Committed:
https://chromium.googlesource.com/external/webrtc/+/4235d78b574aa2923b2e01a9a...
==========

[commit-bot: I haz the power, 2017-07-03 16:11:32]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/4235d78b574aa2923b2e01a9a...