Allow FPS reduction to be applied to frame listeners.

Allow FPS reduction to be applied to frame listeners.

BUG=None

Review-Url: https://codereview.webrtc.org/2897043002
Cr-Commit-Position: refs/heads/master@{#18346}
Committed: https://chromium.googlesource.com/external/webrtc/+/8fdf95728f0bd27755e13b2bea62caaf48529455

[sakal, 2017-05-23 13:47:39]

Description was changed from

==========
Allow FPS reduction to be applied to frame listeners.
==========

to

==========
Allow FPS reduction to be applied to frame listeners.

BUG=None
==========

[sakal, 2017-05-23 13:47:39]

Description was changed from

==========
Allow FPS reduction to be applied to frame listeners.
==========

to

==========
Allow FPS reduction to be applied to frame listeners.

BUG=None
==========

[sakal, 2017-05-23 13:47:39]

sakal@webrtc.org changed reviewers:
+ magjed@webrtc.org

[sakal, 2017-05-23 13:47:39]

sakal@webrtc.org changed reviewers:
+ magjed@webrtc.org

[sakal, 2017-05-23 13:48:02]

Patchset #1 (id:1) has been deleted

[sakal, 2017-05-23 13:48:20]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 13:48:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[sakal, 2017-05-23 13:56:04]

PTAL

[commit-bot: I haz the power, 2017-05-23 14:44:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 14:44:14]

Dry run: This issue passed the CQ dry run.

[magjed_webrtc, 2017-05-26 13:34:45]

https://codereview.webrtc.org/2897043002/diff/20001/webrtc/sdk/android/api/or...
File webrtc/sdk/android/api/org/webrtc/EglRenderer.java (right):

https://codereview.webrtc.org/2897043002/diff/20001/webrtc/sdk/android/api/or...
webrtc/sdk/android/api/org/webrtc/EglRenderer.java:654: VideoRenderer.I420Frame
frame, int[] yuvTextures, float[] texMatrix, boolean wasRenderer) {
spelling nit: wasRendered

https://codereview.webrtc.org/2897043002/diff/20001/webrtc/sdk/android/api/or...
webrtc/sdk/android/api/org/webrtc/EglRenderer.java:659: final
ArrayList<FrameListenerAndParams> fpsReductionApplied = new ArrayList<>();
I would prefer if you use a manual iterator in this case, and use remove() to
remove elements.

[sakal, 2017-05-30 11:53:47]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 11:53:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[sakal, 2017-05-30 11:58:54]

Patchset #2 (id:40001) has been deleted

[sakal, 2017-05-30 12:50:11]

https://codereview.webrtc.org/2897043002/diff/20001/webrtc/sdk/android/api/or...
File webrtc/sdk/android/api/org/webrtc/EglRenderer.java (right):

https://codereview.webrtc.org/2897043002/diff/20001/webrtc/sdk/android/api/or...
webrtc/sdk/android/api/org/webrtc/EglRenderer.java:654: VideoRenderer.I420Frame
frame, int[] yuvTextures, float[] texMatrix, boolean wasRenderer) {
On 2017/05/26 13:34:45, magjed_webrtc wrote:
> spelling nit: wasRendered

Done.

https://codereview.webrtc.org/2897043002/diff/20001/webrtc/sdk/android/api/or...
webrtc/sdk/android/api/org/webrtc/EglRenderer.java:659: final
ArrayList<FrameListenerAndParams> fpsReductionApplied = new ArrayList<>();
On 2017/05/26 13:34:45, magjed_webrtc wrote:
> I would prefer if you use a manual iterator in this case, and use remove() to
> remove elements.

Done.

[magjed_webrtc, 2017-05-30 13:45:44]

lgtm

[sakal, 2017-05-31 09:24:59]

The CQ bit was checked by sakal@webrtc.org

[commit-bot: I haz the power, 2017-05-31 09:25:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-31 09:43:11]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496222699195460,
"parent_rev": "76e62b0d3861c94a9c9ab780ee8bde888ac08170", "commit_rev":
"8fdf95728f0bd27755e13b2bea62caaf48529455"}

[commit-bot: I haz the power, 2017-05-31 09:43:14]

Description was changed from

==========
Allow FPS reduction to be applied to frame listeners.

BUG=None
==========

to

==========
Allow FPS reduction to be applied to frame listeners.

BUG=None

Review-Url: https://codereview.webrtc.org/2897043002
Cr-Commit-Position: refs/heads/master@{#18346}
Committed:
https://chromium.googlesource.com/external/webrtc/+/8fdf95728f0bd27755e13b2be...
==========

[commit-bot: I haz the power, 2017-05-31 09:43:15]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/8fdf95728f0bd27755e13b2be...