Add observer for AVAudioSession.outputVolume

Add observer for AVAudioSession.outputVolume

BUG=webrtc:7696
Review-Url: https://codereview.webrtc.org/2895263006
Cr-Commit-Position: refs/heads/master@{#18267}
Committed: https://chromium.googlesource.com/external/webrtc/+/13ae11a4184c9e1b8d3d68203d0e60365d49b403

[jtt_webrtc, 2017-05-22 22:41:47]

Description was changed from

==========
Add observer for AVAudioSession.outputVolume
==========

to

==========
Add observer for AVAudioSession.outputVolume

BUG=webrtc:7696
==========

[jtt_webrtc, 2017-05-22 22:41:47]

jtteh@webrtc.org changed reviewers:
+ tkchin@webrtc.org

[jtt_webrtc, 2017-05-22 22:42:40]

Allow notification of AVAudioSession outputVolume changes.

[jtt_webrtc, 2017-05-25 17:46:48]

Use the observer new value instead of getting it from
AVAudioSession.outputVolume.

[tkchin_webrtc, 2017-05-25 20:24:33]

https://codereview.webrtc.org/2895263006/diff/20001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/ios/objc/RTCAudioSession.h (right):

https://codereview.webrtc.org/2895263006/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/ios/objc/RTCAudioSession.h:78: -
(void)audioVolumeDidChange:(float)volume;
follow delegate naming convention and use the same property name
- (void)audioSession:(RTCAudioSession *)audioSession
didChangeOutputVolume:(float)outputVolume;

https://codereview.webrtc.org/2895263006/diff/20001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm (right):

https://codereview.webrtc.org/2895263006/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:90: 
nit: remove blank lines

https://codereview.webrtc.org/2895263006/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:820: [self
notifyAudioVolumeDidChange:newVolume];
notifyOutputVolumeDidChange
also, pass the float directly, no need to pass NSNumber around
lastly, log the change maybe?

https://codereview.webrtc.org/2895263006/diff/20001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/ios/objc/RTCAudioSessionDelegateAdapter.mm
(right):

https://codereview.webrtc.org/2895263006/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/ios/objc/RTCAudioSessionDelegateAdapter.mm:84: -
(void)audioVolumeDidChange:(float)volume {
not needed? (since it's optional)

https://codereview.webrtc.org/2895263006/diff/20001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/ios/objc/RTCAudioSessionTest.mm (right):

https://codereview.webrtc.org/2895263006/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/ios/objc/RTCAudioSessionTest.mm:28: @synthesize
outputVolume=_outputVolume;
spaces

https://codereview.webrtc.org/2895263006/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/ios/objc/RTCAudioSessionTest.mm:274:
@{NSKeyValueChangeNewKey : @([AVAudioSession sharedInstance].outputVolume) }
run git clang-format with the .clang-format file in webrtc/sdk/objc ?

[jtt_webrtc, 2017-05-25 21:53:19]

Renamed call back method on delegate.

[jtt_webrtc, 2017-05-25 21:55:06]

On 2017/05/25 20:24:33, tkchin_webrtc wrote:
>
https://codereview.webrtc.org/2895263006/diff/20001/webrtc/modules/audio_devi...
> File webrtc/modules/audio_device/ios/objc/RTCAudioSession.h (right):
> 
>
https://codereview.webrtc.org/2895263006/diff/20001/webrtc/modules/audio_devi...
> webrtc/modules/audio_device/ios/objc/RTCAudioSession.h:78: -
> (void)audioVolumeDidChange:(float)volume;
> follow delegate naming convention and use the same property name
> - (void)audioSession:(RTCAudioSession *)audioSession
> didChangeOutputVolume:(float)outputVolume;
Done.
> 
>
https://codereview.webrtc.org/2895263006/diff/20001/webrtc/modules/audio_devi...
> File webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm (right):
> 
>
https://codereview.webrtc.org/2895263006/diff/20001/webrtc/modules/audio_devi...
> webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:90: 
> nit: remove blank lines
Done.
> 
>
https://codereview.webrtc.org/2895263006/diff/20001/webrtc/modules/audio_devi...
> webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:820: [self
> notifyAudioVolumeDidChange:newVolume];
> notifyOutputVolumeDidChange
> also, pass the float directly, no need to pass NSNumber around
> lastly, log the change maybe?
> 
>
https://codereview.webrtc.org/2895263006/diff/20001/webrtc/modules/audio_devi...
> File webrtc/modules/audio_device/ios/objc/RTCAudioSessionDelegateAdapter.mm
> (right):
> 
>
https://codereview.webrtc.org/2895263006/diff/20001/webrtc/modules/audio_devi...
> webrtc/modules/audio_device/ios/objc/RTCAudioSessionDelegateAdapter.mm:84: -
> (void)audioVolumeDidChange:(float)volume {
> not needed? (since it's optional)
> 
>
https://codereview.webrtc.org/2895263006/diff/20001/webrtc/modules/audio_devi...
> File webrtc/modules/audio_device/ios/objc/RTCAudioSessionTest.mm (right):
> 
>
https://codereview.webrtc.org/2895263006/diff/20001/webrtc/modules/audio_devi...
> webrtc/modules/audio_device/ios/objc/RTCAudioSessionTest.mm:28: @synthesize
> outputVolume=_outputVolume;
> spaces
> 
>
https://codereview.webrtc.org/2895263006/diff/20001/webrtc/modules/audio_devi...
> webrtc/modules/audio_device/ios/objc/RTCAudioSessionTest.mm:274:
> @{NSKeyValueChangeNewKey : @([AVAudioSession sharedInstance].outputVolume) }
> run git clang-format with the .clang-format file in webrtc/sdk/objc ?
That would use 100 cols which will mess up the file.

[tkchin_webrtc, 2017-05-25 23:01:00]

https://codereview.webrtc.org/2895263006/diff/100001/webrtc/modules/audio_dev...
File webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm (right):

https://codereview.webrtc.org/2895263006/diff/100001/webrtc/modules/audio_dev...
webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:821: [super
observeValueForKeyPath:keyPath ofObject:object change:change
nit: either all args on same line, or all on different lines

https://codereview.webrtc.org/2895263006/diff/100001/webrtc/modules/audio_dev...
webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:903: -
(void)notifyAudioVolumeDidChange:(float)volume {
nit: notifyDidChangeOutputVolume

https://codereview.webrtc.org/2895263006/diff/100001/webrtc/modules/audio_dev...
webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:904:
RTCLog(@"AudioVolumeDidChange to %f", volume);
Would place this at the point where you know it changed (ie the observer
method), rather than the function that is called to notify.

Please call it output volume - audio volume could mean many different things.

[jtt_webrtc, 2017-05-25 23:13:44]

On 2017/05/25 23:01:00, tkchin_webrtc wrote:
>
https://codereview.webrtc.org/2895263006/diff/100001/webrtc/modules/audio_dev...
> File webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm (right):
> 
>
https://codereview.webrtc.org/2895263006/diff/100001/webrtc/modules/audio_dev...
> webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:821: [super
> observeValueForKeyPath:keyPath ofObject:object change:change
> nit: either all args on same line, or all on different lines
> 
>
https://codereview.webrtc.org/2895263006/diff/100001/webrtc/modules/audio_dev...
> webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:903: -
> (void)notifyAudioVolumeDidChange:(float)volume {
> nit: notifyDidChangeOutputVolume
> 
>
https://codereview.webrtc.org/2895263006/diff/100001/webrtc/modules/audio_dev...
> webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:904:
> RTCLog(@"AudioVolumeDidChange to %f", volume);
> Would place this at the point where you know it changed (ie the observer
> method), rather than the function that is called to notify.
> 
> Please call it output volume - audio volume could mean many different things.

[jtt_webrtc, 2017-05-25 23:18:19]

On 2017/05/25 23:13:44, jtt wrote:
> On 2017/05/25 23:01:00, tkchin_webrtc wrote:
> >
>
https://codereview.webrtc.org/2895263006/diff/100001/webrtc/modules/audio_dev...
> > File webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm (right):
> > 
> >
>
https://codereview.webrtc.org/2895263006/diff/100001/webrtc/modules/audio_dev...
> > webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:821: [super
> > observeValueForKeyPath:keyPath ofObject:object change:change
> > nit: either all args on same line, or all on different lines
Done
> > 
> >
>
https://codereview.webrtc.org/2895263006/diff/100001/webrtc/modules/audio_dev...
> > webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:903: -
> > (void)notifyAudioVolumeDidChange:(float)volume {
> > nit: notifyDidChangeOutputVolume
> > 
Done
> >
>
https://codereview.webrtc.org/2895263006/diff/100001/webrtc/modules/audio_dev...
> > webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:904:
> > RTCLog(@"AudioVolumeDidChange to %f", volume);
> > Would place this at the point where you know it changed (ie the observer
> > method), rather than the function that is called to notify.
> > 
> > Please call it output volume - audio volume could mean many different
things.
Done

[jtt_webrtc, 2017-05-25 23:22:38]

Method rename and cleanup.

[tkchin_webrtc, 2017-05-25 23:47:37]

lgtm

https://codereview.webrtc.org/2895263006/diff/120001/webrtc/modules/audio_dev...
File webrtc/modules/audio_device/ios/objc/RTCAudioSessionDelegateAdapter.mm
(right):

https://codereview.webrtc.org/2895263006/diff/120001/webrtc/modules/audio_dev...
webrtc/modules/audio_device/ios/objc/RTCAudioSessionDelegateAdapter.mm:84: -
(void)audioSession:(RTCAudioSession *)audioSession
nit: probably don't need this here

[jtt_webrtc, 2017-05-26 00:27:58]

The CQ bit was checked by jtteh@webrtc.org

[commit-bot: I haz the power, 2017-05-26 00:28:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-26 00:52:21]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1495758478731670,
"parent_rev": "a615e17ec0ad7739b367034473ab3312299e70da", "commit_rev":
"13ae11a4184c9e1b8d3d68203d0e60365d49b403"}

[commit-bot: I haz the power, 2017-05-26 00:52:26]

Description was changed from

==========
Add observer for AVAudioSession.outputVolume

BUG=webrtc:7696
==========

to

==========
Add observer for AVAudioSession.outputVolume

BUG=webrtc:7696

Review-Url: https://codereview.webrtc.org/2895263006
Cr-Commit-Position: refs/heads/master@{#18267}
Committed:
https://chromium.googlesource.com/external/webrtc/+/13ae11a4184c9e1b8d3d68203...
==========

[commit-bot: I haz the power, 2017-05-26 00:52:32]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/external/webrtc/+/13ae11a4184c9e1b8d3d68203...