Change rtp_event_log2text to ignore webrtc::MediaType from proto.

Change rtp_event_log2text to ignore webrtc::MediaType from proto.

BUG=webrtc:7538
Review-Url: https://codereview.webrtc.org/2894833003
Cr-Commit-Position: refs/heads/master@{#18210}
Committed: https://chromium.googlesource.com/external/webrtc/+/c52bd61f65d04b364e90a672691963d089ca5141

[perkj_webrtc, 2017-05-19 10:48:35]

Description was changed from

==========
Fix.


Change rtp_event_log2text to ignore webrtc::MediaType from proto.

BUG=
==========

to

==========
Change rtp_event_log2text to ignore webrtc::MediaType from proto.

BUG=webrtc:7538
==========

[perkj_webrtc, 2017-05-19 10:48:35]

perkj@webrtc.org changed reviewers:
+ terelius@webrtc.org

[perkj_webrtc, 2017-05-19 10:55:48]

The CQ bit was checked by perkj@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 10:55:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[perkj_webrtc, 2017-05-19 10:55:58]

Please?

[commit-bot: I haz the power, 2017-05-19 11:17:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 11:17:17]

Dry run: This issue passed the CQ dry run.

[perkj_webrtc, 2017-05-19 11:38:30]

Please?

[terelius, 2017-05-19 11:55:59]

https://codereview.webrtc.org/2894833003/diff/20001/webrtc/logging/rtc_event_...
File webrtc/logging/rtc_event_log/rtc_event_log2text.cc (right):

https://codereview.webrtc.org/2894833003/diff/20001/webrtc/logging/rtc_event_...
webrtc/logging/rtc_event_log/rtc_event_log2text.cc:76: // Struct used for
storing all SSRCs used in a Stream.
Why "all"? The struct only holds one SSRC.

https://codereview.webrtc.org/2894833003/diff/20001/webrtc/logging/rtc_event_...
webrtc/logging/rtc_event_log/rtc_event_log2text.cc:396: if
(config.rtp.flexfec.ssrc > 0) {
We don't log FlexFEC SSRCs, so this is always going to be empty. It also does
not exist in your upcoming StreamConfig struct.

[perkj_webrtc, 2017-05-19 12:02:52]

ptal

https://codereview.webrtc.org/2894833003/diff/20001/webrtc/logging/rtc_event_...
File webrtc/logging/rtc_event_log/rtc_event_log2text.cc (right):

https://codereview.webrtc.org/2894833003/diff/20001/webrtc/logging/rtc_event_...
webrtc/logging/rtc_event_log/rtc_event_log2text.cc:76: // Struct used for
storing all SSRCs used in a Stream.
On 2017/05/19 11:55:59, terelius wrote:
> Why "all"? The struct only holds one SSRC.

Done.

https://codereview.webrtc.org/2894833003/diff/20001/webrtc/logging/rtc_event_...
webrtc/logging/rtc_event_log/rtc_event_log2text.cc:396: if
(config.rtp.flexfec.ssrc > 0) {
On 2017/05/19 11:55:59, terelius wrote:
> We don't log FlexFEC SSRCs, so this is always going to be empty. It also does
> not exist in your upcoming StreamConfig struct.

removed.

[terelius, 2017-05-19 12:08:25]

lgtm

[perkj_webrtc, 2017-05-19 12:14:12]

The CQ bit was checked by perkj@webrtc.org

[commit-bot: I haz the power, 2017-05-19 12:14:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-19 12:32:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495196052712270,
"parent_rev": "30df64f14306072ea9c612828450abf760f893f7", "commit_rev":
"c52bd61f65d04b364e90a672691963d089ca5141"}

[commit-bot: I haz the power, 2017-05-19 12:33:01]

Description was changed from

==========
Change rtp_event_log2text to ignore webrtc::MediaType from proto.

BUG=webrtc:7538
==========

to

==========
Change rtp_event_log2text to ignore webrtc::MediaType from proto.

BUG=webrtc:7538

Review-Url: https://codereview.webrtc.org/2894833003
Cr-Commit-Position: refs/heads/master@{#18210}
Committed:
https://chromium.googlesource.com/external/webrtc/+/c52bd61f65d04b364e90a6726...
==========

[commit-bot: I haz the power, 2017-05-19 12:33:02]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/c52bd61f65d04b364e90a6726...