Force keyframe for Qualcomm HW VP8 Encoder on Android L as well, reduce forced keyframe interval on…

Force keyframe for Qualcomm HW VP8 Encoder on Android L as well, reduce forced keyframe interval on Android M.

Color distortion also happens on Android L. Tested on the Mi 4.

BUG=webrtc:7681
Review-Url: https://codereview.webrtc.org/2894643003
Cr-Commit-Position: refs/heads/master@{#18423}
Committed: https://chromium.googlesource.com/external/webrtc/+/84ee5c64d3ebccf8d4b416792222d9dd7844e830

[alexlau, 2017-05-18 18:23:25]

Description was changed from

==========
Force keyframe for Qualcomm HW VP8 Encoder on Android L as well, reduce forced
keyframe interval on Android M.

Color distortion also happens on Android L. Tested on the Mi 4.

BUG=webrtc:7681
==========

to

==========
Force keyframe for Qualcomm HW VP8 Encoder on Android L as well, reduce forced
keyframe interval on Android M.

Color distortion also happens on Android L. Tested on the Mi 4.

BUG=webrtc:7681
==========

[alexlau, 2017-05-18 18:23:25]

alexlau@webrtc.org changed reviewers:
+ glaznev@webrtc.org, wzh@webrtc.org

[AlexG, 2017-05-30 23:11:56]

lgtm

https://codereview.webrtc.org/2894643003/diff/1/webrtc/sdk/android/api/org/we...
File webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java (right):

https://codereview.webrtc.org/2894643003/diff/1/webrtc/sdk/android/api/org/we...
webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java:58: private static
final long QCOM_VP8_KEY_FRAME_INTERVAL_ANDROID_M_MS = 15000;
May be 20 sec - somewhere in between 15 and 25?

[alexlau, 2017-06-03 00:11:46]

The CQ bit was checked by alexlau@webrtc.org

[alexlau, 2017-06-03 00:11:47]

The CQ bit was unchecked by alexlau@webrtc.org

[alexlau, 2017-06-03 00:11:48]

The CQ bit was checked by alexlau@webrtc.org

[alexlau, 2017-06-03 00:11:52]

The CQ bit was unchecked by alexlau@webrtc.org

[alexlau, 2017-06-03 00:11:52]

The CQ bit was checked by alexlau@webrtc.org

[commit-bot: I haz the power, 2017-06-03 00:11:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[alexlau, 2017-06-03 00:12:02]

The CQ bit was unchecked by alexlau@webrtc.org

[alexlau, 2017-06-03 00:16:00]

https://codereview.webrtc.org/2894643003/diff/1/webrtc/sdk/android/api/org/we...
File webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java (right):

https://codereview.webrtc.org/2894643003/diff/1/webrtc/sdk/android/api/org/we...
webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java:58: private static
final long QCOM_VP8_KEY_FRAME_INTERVAL_ANDROID_M_MS = 15000;
On 2017/05/30 23:11:56, AlexG wrote:
> May be 20 sec - somewhere in between 15 and 25?

Done.

[alexlau, 2017-06-03 00:16:25]

The CQ bit was checked by alexlau@webrtc.org

[alexlau, 2017-06-03 00:16:25]

The patchset sent to the CQ was uploaded after l-g-t-m from glaznev@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2894643003/#ps20001 (title:
"set forced keyframe update time to 20s for M")

[commit-bot: I haz the power, 2017-06-03 00:16:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-03 00:36:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496448985274870,
"parent_rev": "e907741a211ba26b666867f0758a687f68e0e1b3", "commit_rev":
"84ee5c64d3ebccf8d4b416792222d9dd7844e830"}

[commit-bot: I haz the power, 2017-06-03 00:36:37]

Description was changed from

==========
Force keyframe for Qualcomm HW VP8 Encoder on Android L as well, reduce forced
keyframe interval on Android M.

Color distortion also happens on Android L. Tested on the Mi 4.

BUG=webrtc:7681
==========

to

==========
Force keyframe for Qualcomm HW VP8 Encoder on Android L as well, reduce forced
keyframe interval on Android M.

Color distortion also happens on Android L. Tested on the Mi 4.

BUG=webrtc:7681

Review-Url: https://codereview.webrtc.org/2894643003
Cr-Commit-Position: refs/heads/master@{#18423}
Committed:
https://chromium.googlesource.com/external/webrtc/+/84ee5c64d3ebccf8d4b416792...
==========

[commit-bot: I haz the power, 2017-06-03 00:36:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/84ee5c64d3ebccf8d4b416792...