Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2893933003: Land ContextUtils separately. (Closed)

Created:
3 years, 7 months ago by sakal
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Land ContextUtils separately. External dependencies need to be updated to call ContextUtils.initialize before rest of the CL can be landed. BUG=webrtc:7665 Review-Url: https://codereview.webrtc.org/2893933003 Cr-Commit-Position: refs/heads/master@{#18208} Committed: https://chromium.googlesource.com/external/webrtc/+/633e22ebbe09a7c2cb8976fc878dd389e0007fc8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M webrtc/base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A webrtc/base/java/src/org/webrtc/ContextUtils.java View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
sakal
PTAL
3 years, 7 months ago (2017-05-19 07:50:27 UTC) #3
sakal
PTAL
3 years, 7 months ago (2017-05-19 07:50:28 UTC) #4
henrika_webrtc
lgtm
3 years, 7 months ago (2017-05-19 08:26:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2893933003/1
3 years, 7 months ago (2017-05-19 08:26:54 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 08:29:16 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/633e22ebbe09a7c2cb8976fc8...

Powered by Google App Engine
This is Rietveld 408576698