Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2893723002: Add methods to change enabled events in PhysicalSocket. (Closed)

Created:
3 years, 7 months ago by joachim
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add methods to change enabled events in PhysicalSocket. This is in preparation for "epoll" integration where additional code needs to run when the enabled events change. BUG=webrtc:7585 Review-Url: https://codereview.webrtc.org/2893723002 Cr-Commit-Position: refs/heads/master@{#18189} Committed: https://chromium.googlesource.com/external/webrtc/+/577f5dc60b2f129c947fce7a38597781282bf3a5

Patch Set 1 #

Messages

Total messages: 9 (5 generated)
joachim
Ptal, this is the separated CL from https://codereview.webrtc.org/2880923002/ I also changed "enabled_events_" to be private ...
3 years, 7 months ago (2017-05-17 20:33:02 UTC) #3
Taylor Brandstetter
lgtm
3 years, 7 months ago (2017-05-17 22:27:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2893723002/1
3 years, 7 months ago (2017-05-17 22:27:43 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 23:32:31 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/577f5dc60b2f129c947fce7a3...

Powered by Google App Engine
This is Rietveld 408576698