Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2893003002: Revert of Reuse allocated encoders in SimulcastEncoderAdapter. (Closed)

Created:
3 years, 7 months ago by brandtr
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Reuse allocated encoders in SimulcastEncoderAdapter. (patchset #15 id:320001 of https://codereview.webrtc.org/2830793005/ ) Reason for revert: Breaks Chrome tests. Original issue's description: > Reuse allocated encoders in SimulcastEncoderAdapter. > > Prior to this change, the SimulcastEncoderAdapter would destroy and create > encoders whenever it is being reinitialized. After this change, the > SimulcastEncoderAdapter will cache the already allocated encoders, and reuse > them after reinitialization. > > This change will help in reducing the number of PictureID "jumps" that have > been seen around encoder reinitialization. > > TESTED=AppRTCMobile, Chrome desktop, and internal app, with forced encoder reinits every 30 frames and https://codereview.webrtc.org/2833493003/ applied. > BUG=webrtc:7475 > > Review-Url: https://codereview.webrtc.org/2830793005 > Cr-Commit-Position: refs/heads/master@{#18215} > Committed: https://chromium.googlesource.com/external/webrtc/+/0b8bfb9d98b7a2011d80bcdf3f430bc040370dad TBR=stefan@webrtc.org,noahric@chromium.org,glaznev@webrtc.org,sprang@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7475 Review-Url: https://codereview.webrtc.org/2893003002 Cr-Commit-Position: refs/heads/master@{#18216} Committed: https://chromium.googlesource.com/external/webrtc/+/56e119e2e8b30d2d41c55c3a7983b077a5262718

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -625 lines) Patch
M webrtc/modules/video_coding/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.h View 3 chunks +21 lines, -32 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc View 14 chunks +44 lines, -106 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc View 9 chunks +9 lines, -231 lines 0 comments Download
M webrtc/video/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/end_to_end_tests.cc View 5 chunks +3 lines, -253 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
brandtr
Created Revert of Reuse allocated encoders in SimulcastEncoderAdapter.
3 years, 7 months ago (2017-05-19 17:32:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2893003002/1
3 years, 7 months ago (2017-05-19 17:32:57 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/56e119e2e8b30d2d41c55c3a7983b077a5262718
3 years, 7 months ago (2017-05-19 17:33:10 UTC) #6
brandtr
3 years, 7 months ago (2017-05-22 07:12:21 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2901493002/ by brandtr@webrtc.org.

The reason for reverting is: Don't call RegisterEncodeCallback(nullptr), to
satisfy test..

Powered by Google App Engine
This is Rietveld 408576698