Change how event_log_visualizer ignore duplicate incoming RTCP packets.

Change how event_log_visualizer ignore duplicate incoming RTCP packets.
Instead of only looking at Audio or ANY media type, we ignore duplicate RTCP packets.

BUG=webrtc:7538
Review-Url: https://codereview.webrtc.org/2892913002
Cr-Commit-Position: refs/heads/master@{#18213}
Committed: https://chromium.googlesource.com/external/webrtc/+/bbbad6da7e7ba0ab8a0e2645213db80ba2445cbe

[perkj_webrtc, 2017-05-19 11:38:18]

The CQ bit was checked by perkj@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 11:38:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[perkj_webrtc, 2017-05-19 11:39:18]

perkj@webrtc.org changed reviewers:
+ terelius@webrtc.org

[perkj_webrtc, 2017-05-19 11:39:19]

Please

[terelius, 2017-05-19 12:07:32]

https://codereview.webrtc.org/2892913002/diff/1/webrtc/tools/event_log_visual...
File webrtc/tools/event_log_visualizer/analyzer.cc (right):

https://codereview.webrtc.org/2892913002/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/analyzer.cc:412:
memcmp(last_incoming_rtcp_packet, packet, IP_PACKET_SIZE) == 0) {
This reads outside the actual packet. Maybe store size_t
last_incoming_rtcp_packet_size too?

https://codereview.webrtc.org/2892913002/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/analyzer.cc:415:
memcpy(last_incoming_rtcp_packet, packet, IP_PACKET_SIZE);
Doesn't this copy outgoing RTCP into last_incoming_rtcp_packet?

[commit-bot: I haz the power, 2017-05-19 12:09:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 12:09:43]

Dry run: This issue passed the CQ dry run.

[perkj_webrtc, 2017-05-19 12:29:05]

https://codereview.webrtc.org/2892913002/diff/1/webrtc/tools/event_log_visual...
File webrtc/tools/event_log_visualizer/analyzer.cc (right):

https://codereview.webrtc.org/2892913002/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/analyzer.cc:412:
memcmp(last_incoming_rtcp_packet, packet, IP_PACKET_SIZE) == 0) {
On 2017/05/19 12:07:32, terelius wrote:
> This reads outside the actual packet. Maybe store size_t
> last_incoming_rtcp_packet_size too?

both are of size IP_PACKET_SIZE. Sure I can store a separate variable as well if
you prefer.

https://codereview.webrtc.org/2892913002/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/analyzer.cc:415:
memcpy(last_incoming_rtcp_packet, packet, IP_PACKET_SIZE);
On 2017/05/19 12:07:32, terelius wrote:
> Doesn't this copy outgoing RTCP into last_incoming_rtcp_packet?

.... eh, good cath.... But it does not matter. I will fix though.

[terelius, 2017-05-19 12:47:02]

https://codereview.webrtc.org/2892913002/diff/1/webrtc/tools/event_log_visual...
File webrtc/tools/event_log_visualizer/analyzer.cc (right):

https://codereview.webrtc.org/2892913002/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/analyzer.cc:412:
memcmp(last_incoming_rtcp_packet, packet, IP_PACKET_SIZE) == 0) {
On 2017/05/19 12:29:05, perkj_webrtc wrote:
> On 2017/05/19 12:07:32, terelius wrote:
> > This reads outside the actual packet. Maybe store size_t
> > last_incoming_rtcp_packet_size too?
> 
> both are of size IP_PACKET_SIZE. Sure I can store a separate variable as well
if
> you prefer. 

The buffers are of size IP_PACKET_SIZE, but the actual packet data is less. As
is, the code would compare the RTCP packet to the beginning of the previous
packet and then compare the uninitialized part to the packet buffer to the
remainder of the previous packet.

[terelius, 2017-05-19 12:58:43]

lgtm

[perkj_webrtc, 2017-05-19 13:02:44]

The CQ bit was checked by perkj@webrtc.org

[commit-bot: I haz the power, 2017-05-19 13:02:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-19 13:30:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495198964750050,
"parent_rev": "eed52bff8d3e2d83207da624ec0a8f6441f1c98f", "commit_rev":
"bbbad6da7e7ba0ab8a0e2645213db80ba2445cbe"}

[commit-bot: I haz the power, 2017-05-19 13:30:33]

Description was changed from

==========
Change how event_log_visualizer ignore duplicate incoming RTCP packets.
Instead of only looking at Audio or ANY media type, we ignore duplicate RTCP
packets.

BUG=webrtc:7538
==========

to

==========
Change how event_log_visualizer ignore duplicate incoming RTCP packets.
Instead of only looking at Audio or ANY media type, we ignore duplicate RTCP
packets.

BUG=webrtc:7538

Review-Url: https://codereview.webrtc.org/2892913002
Cr-Commit-Position: refs/heads/master@{#18213}
Committed:
https://chromium.googlesource.com/external/webrtc/+/bbbad6da7e7ba0ab8a0e26452...
==========

[commit-bot: I haz the power, 2017-05-19 13:30:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/bbbad6da7e7ba0ab8a0e26452...