Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 2892723002: MB: Add WebRTC codesearch builder config (Closed)

Created:
3 years, 7 months ago by kjellander_webrtc
Modified:
3 years, 7 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

MB: Add WebRTC codesearch builder config Identical to Chromium's code search builders with the exception that is_component_build=true is not set, as it doesn't have any effect on WebRTC builds. Adding strip_absolute_paths_from_debug_symbols=true to the minimal_symbols mixin as recently changed in Chromium. BUG=chromium:699463 NOTRY=True Review-Url: https://codereview.webrtc.org/2892723002 Cr-Commit-Position: refs/heads/master@{#18192} Committed: https://chromium.googlesource.com/external/webrtc/+/8838f13072c57d25b3bd456be20fff410a29c291

Patch Set 1 #

Patch Set 2 : Flattened #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M tools_webrtc/mb/mb_config.pyl View 1 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
kjellander_webrtc
3 years, 7 months ago (2017-05-18 10:26:44 UTC) #2
ehmaldonado_webrtc
On 2017/05/18 10:26:44, kjellander_webrtc wrote: lgtm
3 years, 7 months ago (2017-05-18 10:29:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2892723002/20001
3 years, 7 months ago (2017-05-18 10:30:37 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 10:32:55 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/8838f13072c57d25b3bd456be...

Powered by Google App Engine
This is Rietveld 408576698