Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2892583002: Don't add FEC and RTX overheads when calculating a padding packet's maximum payload size. (Closed)

Created:
3 years, 7 months ago by erikvarga1
Modified:
3 years, 7 months ago
Reviewers:
danilchap
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't add FEC and RTX overheads when calculating a padding packet's maximum payload size. BUG=webrtc:7433 Review-Url: https://codereview.webrtc.org/2892583002 Cr-Commit-Position: refs/heads/master@{#18184} Committed: https://chromium.googlesource.com/external/webrtc/+/76a5593835af6a6696125973005c487b4d7cf76b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
erikvarga1
3 years, 7 months ago (2017-05-17 14:04:16 UTC) #3
danilchap
lgtm
3 years, 7 months ago (2017-05-17 14:12:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2892583002/1
3 years, 7 months ago (2017-05-17 14:26:13 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 14:50:22 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/76a5593835af6a66961259730...

Powered by Google App Engine
This is Rietveld 408576698