Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2892483003:
Add class level comments to ComputedStyle. (Closed)
DescriptionAdd class level comments to ComputedStyle.
This patch adds class level comments to ComputedStyle. A future patch
will document ComputedStyleBase as well.
Review-Url: https://codereview.chromium.org/2892483003
Cr-Commit-Position: refs/heads/master@{#474946}
Committed: https://chromium.googlesource.com/chromium/src/+/69b92a95fb72a2d887e7863ae3e038455d45a00f
Patch Set 1 #
Total comments: 10
Patch Set 2 : Rebase #Patch Set 3 : Rebase #Patch Set 4 : Rebase #Messages
Total messages: 21 (14 generated)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
meade@chromium.org changed reviewers: + meade@chromium.org
very nice, lgtm
nainar@chromium.org changed reviewers: + nainar@chromium.org
lgtm with nits https://codereview.chromium.org/2892483003/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/style/ComputedStyle.h (right): https://codereview.chromium.org/2892483003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/style/ComputedStyle.h:140: // ComputedStyle stores the resolved style for an element and provides the Define resolved here. https://codereview.chromium.org/2892483003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/style/ComputedStyle.h:145: // auto style = ComputedStyle::Create() style->SetDisplay(EDisplay::kNone); // erroneous // at the end of this line? https://codereview.chromium.org/2892483003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/style/ComputedStyle.h:150: // include pseudo element styles, unique_ (for style sharing) and explain that PseudoStyleCache is where we store the pseudo elements style like was done for other elements.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
https://codereview.chromium.org/2892483003/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/style/ComputedStyle.h (right): https://codereview.chromium.org/2892483003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/style/ComputedStyle.h:140: // ComputedStyle stores the resolved style for an element and provides the Should I explain the concept of computed/resolved values? https://codereview.chromium.org/2892483003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/style/ComputedStyle.h:140: // ComputedStyle stores the resolved style for an element and provides the On 2017/05/17 at 02:48:27, nainar wrote: > Define resolved here. Done. https://codereview.chromium.org/2892483003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/style/ComputedStyle.h:145: // auto style = ComputedStyle::Create() style->SetDisplay(EDisplay::kNone); // On 2017/05/17 at 02:48:27, nainar wrote: > erroneous // at the end of this line? Done https://codereview.chromium.org/2892483003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/style/ComputedStyle.h:150: // include pseudo element styles, unique_ (for style sharing) and On 2017/05/17 at 02:48:27, nainar wrote: > explain that PseudoStyleCache is where we store the pseudo elements style like was done for other elements. Done. https://codereview.chromium.org/2892483003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/style/ComputedStyle.h:168: // ComputedStyle is optimized for memory and performance. The data is not Would headings be useful?
https://codereview.chromium.org/2892483003/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/style/ComputedStyle.h (right): https://codereview.chromium.org/2892483003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/style/ComputedStyle.h:140: // ComputedStyle stores the resolved style for an element and provides the On 2017/05/17 at 03:42:32, shend wrote: > Should I explain the concept of computed/resolved values? If you can find a MDN link sure otherwise its ok. https://codereview.chromium.org/2892483003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/style/ComputedStyle.h:168: // ComputedStyle is optimized for memory and performance. The data is not On 2017/05/17 at 03:42:32, shend wrote: > Would headings be useful? Headings are always useful :)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shend@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org, nainar@chromium.org Link to the patchset: https://codereview.chromium.org/2892483003/#ps60001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495780721125370,
"parent_rev": "b6226310dcb07800431471cdd6ffb36fa1c21925", "commit_rev":
"69b92a95fb72a2d887e7863ae3e038455d45a00f"}
Message was sent while issue was closed.
Description was changed from ========== Add class level comments to ComputedStyle. This patch adds class level comments to ComputedStyle. A future patch will document ComputedStyleBase as well. ========== to ========== Add class level comments to ComputedStyle. This patch adds class level comments to ComputedStyle. A future patch will document ComputedStyleBase as well. Review-Url: https://codereview.chromium.org/2892483003 Cr-Commit-Position: refs/heads/master@{#474946} Committed: https://chromium.googlesource.com/chromium/src/+/69b92a95fb72a2d887e7863ae3e0... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/69b92a95fb72a2d887e7863ae3e0... |
