Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2892453003: Reduce dependencies on rtc::FileSystem in FileRotatingStream tests (Closed)

Created:
3 years, 7 months ago by charujain1
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc, tkchin_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Reduce dependencies on rtc::FileSystem in FileRotatingStream tests, adding helpers in webrtc::test:: (patchset #7 id:120001 of https://codereview.webrtc.org/2872283002/ ) Reason for revert: Fails to compile successfully. Original issue's description: > Reduce dependencies on rtc::FileSystem in FileRotatingStream tests. > > Use webrtc::test::OutputPath instead of Filesystem::GetAppTempFolder. > Added functions RemoveFile and RemoveDir in the webrtc::test namespace, > to replace use of Filesystem::DeleteFolderAndContents. > > This makes Filesystem::DeleteFolderAndContents unused, to be deleted > together with related code in a followup cl. > > BUG=webrtc:7345 > > Review-Url: https://codereview.webrtc.org/2872283002 > Cr-Commit-Position: refs/heads/master@{#18173} > Committed: https://chromium.googlesource.com/external/webrtc/+/dd7b5f32b59d9def668b9e9487589a572f20f6e0 TBR=pthatcher@webrtc.org,kjellander@webrtc.org,tommi@webrtc.org,nisse@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7345

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -55 lines) Patch
M webrtc/base/filerotatingstream.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/filerotatingstream_unittest.cc View 3 chunks +20 lines, -32 lines 0 comments Download
M webrtc/test/testsupport/fileutils.h View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/test/testsupport/fileutils.cc View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 31 (26 generated)
charujain1
Created Revert of Reduce dependencies on rtc::FileSystem in FileRotatingStream tests, adding helpers in webrtc::test::
3 years, 7 months ago (2017-05-17 11:52:05 UTC) #2
ehmaldonado_webrtc
On 2017/05/17 11:52:05, charujain1 wrote: > Created Revert of Reduce dependencies on rtc::FileSystem in FileRotatingStream ...
3 years, 7 months ago (2017-05-17 12:30:11 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2892453003/1
3 years, 7 months ago (2017-05-17 12:30:22 UTC) #26
kjellander_webrtc
lgtm
3 years, 7 months ago (2017-05-17 12:30:24 UTC) #27
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 12:30:26 UTC) #29
Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/heads/master'.
nothing to commit, working tree clean

Powered by Google App Engine
This is Rietveld 408576698