MB: Make Code Search builders use the phase configs.

MB: Make Code Search builders use the phase configs.

The code search recipe passes --phase flag to the MB command
(see https://chromium-review.googlesource.com/c/505619/7)
so the MB config needs to be configured to support this.

BUG=chromium:699463
NOTRY=True

Review-Url: https://codereview.webrtc.org/2891583005
Cr-Commit-Position: refs/heads/master@{#18202}
Committed: https://chromium.googlesource.com/external/webrtc/+/fb0ff45aa002f7da7aafed666de315f2209580a6

[kjellander_webrtc, 2017-05-18 13:11:38]

Description was changed from

==========
MB: Make Code Search builders use the phase feature.

The Code search recipe assumes the MB config to be using
build phases (for future multiple-platform builds).
This change updates our configs to use that.

BUG=chromium:699463
==========

to

==========
MB: Make Code Search builders use the phase configs.

The Code search recipe assumes the MB config to be using
build phases (for future multiple-platform builds).
This change updates our configs to use that.

BUG=chromium:699463
NOTRY=True
==========

[kjellander_webrtc, 2017-05-18 13:11:38]

kjellander@webrtc.org changed reviewers:
+ ehmaldonado@webrtc.org

[ehmaldonado_webrtc, 2017-05-18 13:23:09]

On 2017/05/18 13:11:44, kjellander_webrtc wrote:

So, how does this work?

[kjellander_webrtc, 2017-05-18 14:55:21]

Description was changed from

==========
MB: Make Code Search builders use the phase configs.

The Code search recipe assumes the MB config to be using
build phases (for future multiple-platform builds).
This change updates our configs to use that.

BUG=chromium:699463
NOTRY=True
==========

to

==========
MB: Make Code Search builders use the phase configs.

The code search recipe passes --phase flag to the MB command
(see https://chromium-review.googlesource.com/c/505619/7)
so the MB config needs to be configured to support this.

BUG=chromium:699463
NOTRY=True
==========

[kjellander_webrtc, 2017-05-18 14:57:10]

On 2017/05/18 13:23:09, ehmaldonado_webrtc wrote:
> On 2017/05/18 13:11:44, kjellander_webrtc wrote:
> 
> So, how does this work?

I updated the CL description, the recipe invokes mb.py with the --phase
<platform> flag, so we need to align with what's expected.
See
https://chromium.googlesource.com/chromium/src/+/master/tools/mb/mb_config.py...
In there, there's one bot that has two phases. I don't think we'll need that
anytime soon, but we need to have the right config.

[ehmaldonado_webrtc, 2017-05-18 15:08:17]

On 2017/05/18 14:57:10, kjellander_webrtc wrote:
> On 2017/05/18 13:23:09, ehmaldonado_webrtc wrote:
> > On 2017/05/18 13:11:44, kjellander_webrtc wrote:
> > 
> > So, how does this work?
> 
> I updated the CL description, the recipe invokes mb.py with the --phase
> <platform> flag, so we need to align with what's expected.
> See
>
https://chromium.googlesource.com/chromium/src/+/master/tools/mb/mb_config.py...
> In there, there's one bot that has two phases. I don't think we'll need that
> anytime soon, but we need to have the right config.

Got it, lgtm

[kjellander_webrtc, 2017-05-18 20:01:34]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2017-05-18 20:01:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-18 20:04:31]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495137694402790, "parent_rev":
"8eef7aa7cf165401fe4083b02334890097e5b003", "commit_rev":
"fb0ff45aa002f7da7aafed666de315f2209580a6"}

[commit-bot: I haz the power, 2017-05-18 20:04:35]

Description was changed from

==========
MB: Make Code Search builders use the phase configs.

The code search recipe passes --phase flag to the MB command
(see https://chromium-review.googlesource.com/c/505619/7)
so the MB config needs to be configured to support this.

BUG=chromium:699463
NOTRY=True
==========

to

==========
MB: Make Code Search builders use the phase configs.

The code search recipe passes --phase flag to the MB command
(see https://chromium-review.googlesource.com/c/505619/7)
so the MB config needs to be configured to support this.

BUG=chromium:699463
NOTRY=True

Review-Url: https://codereview.webrtc.org/2891583005
Cr-Commit-Position: refs/heads/master@{#18202}
Committed:
https://chromium.googlesource.com/external/webrtc/+/fb0ff45aa002f7da7aafed666...
==========

[commit-bot: I haz the power, 2017-05-18 20:04:36]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/fb0ff45aa002f7da7aafed666...