Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2890223002: Update plot_webrtc_test_logs.py: (Closed)

Created:
3 years, 7 months ago by åsapersson
Modified:
3 years, 7 months ago
Reviewers:
brandtr
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update plot_webrtc_test_logs.py: - Add codec_type-implementation_name label option. - Update figure title to exclude information that exist in legend. - Change frame info in title from: # of frames in file -> # of processed frames. BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/2890223002 Cr-Commit-Position: refs/heads/master@{#18209} Committed: https://chromium.googlesource.com/external/webrtc/+/30df64f14306072ea9c612828450abf760f893f7

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -39 lines) Patch
M webrtc/modules/video_coding/codecs/test/plot_webrtc_test_logs.py View 1 8 chunks +44 lines, -32 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.cc View 4 chunks +9 lines, -5 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
åsapersson
3 years, 7 months ago (2017-05-19 10:20:59 UTC) #4
brandtr
Nice! lgtm
3 years, 7 months ago (2017-05-19 10:31:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2890223002/20001
3 years, 7 months ago (2017-05-19 11:05:06 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 11:07:44 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/30df64f14306072ea9c612828...

Powered by Google App Engine
This is Rietveld 408576698