Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2888643003: Remove gflags dependency for screenshare_loopback (Closed)

Created:
3 years, 7 months ago by kjellander_webrtc
Modified:
3 years, 7 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove gflags dependency for screenshare_loopback BUG=webrtc:7644 NOTRY=True Review-Url: https://codereview.webrtc.org/2888643003 Cr-Commit-Position: refs/heads/master@{#18186} Committed: https://chromium.googlesource.com/external/webrtc/+/12fa8f444c0e7dec42c37caee457b2f02b0e95aa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -72 lines) Patch
M webrtc/video/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/screenshare_loopback.cc View 9 chunks +78 lines, -71 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kjellander_webrtc
3 years, 7 months ago (2017-05-16 20:27:32 UTC) #2
kjellander_webrtc
Friendly ping
3 years, 7 months ago (2017-05-17 17:56:46 UTC) #3
sprang_webrtc
lgtm
3 years, 7 months ago (2017-05-17 18:17:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2888643003/1
3 years, 7 months ago (2017-05-17 18:17:31 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 18:20:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/12fa8f444c0e7dec42c37caee...

Powered by Google App Engine
This is Rietveld 408576698