Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2887593003: Tracking mock_paced_sender.h with a GN target (Closed)

Created:
3 years, 7 months ago by mbonadei
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Tracking mock_paced_sender.h with a GN target Untracked headers fly under the 'gn check' radar and in the long term this can cause problems like unnoticed cyclic dependencies. This cl creates a synthetic target for this header since no other targets in webrtc/modules/pacing/BUILD.gn seem to be related to it. BUG=webrtc:7649 NOTRY=True Review-Url: https://codereview.webrtc.org/2887593003 Cr-Commit-Position: refs/heads/master@{#19656} Committed: https://chromium.googlesource.com/external/webrtc/+/334f9e6a8d67f646b1a60a1683046224c351c5a4

Patch Set 1 #

Patch Set 2 : Rebasing and re-running dependency checker #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M webrtc/call/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/bitrate_controller/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/pacing/BUILD.gn View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
mbonadei
3 years, 7 months ago (2017-05-16 09:28:34 UTC) #2
phoglund
Ping Åsa, Stefan
3 years, 3 months ago (2017-09-04 07:21:43 UTC) #5
mbonadei
On 2017/09/04 07:21:43, phoglund_ooo_parental_leave wrote: > Ping Åsa, Stefan Thanks, PS#2 has been updated because ...
3 years, 3 months ago (2017-09-04 07:46:54 UTC) #6
mbonadei
Added Henrik for the LGTM since I am only changing BUILD.gn files. Åsa, Stefan just ...
3 years, 3 months ago (2017-09-04 11:06:51 UTC) #8
kjellander_webrtc
lgtm
3 years, 3 months ago (2017-09-04 11:49:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2887593003/20001
3 years, 3 months ago (2017-09-04 11:55:00 UTC) #11
commit-bot: I haz the power
3 years, 3 months ago (2017-09-04 11:57:17 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/334f9e6a8d67f646b1a60a168...

Powered by Google App Engine
This is Rietveld 408576698