Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2374)

Unified Diff: webrtc/call/rtp_transport_controller_receive_interface.h

Issue 2886993005: Introduce RtpStreamReceiver and RtpStreamReceiverControllerInterface. (Closed)
Patch Set: Fix FlexFEC. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/call/rtp_transport_controller_receive_interface.h
diff --git a/webrtc/call/rtp_transport_controller_receive_interface.h b/webrtc/call/rtp_transport_controller_receive_interface.h
new file mode 100644
index 0000000000000000000000000000000000000000..6bebc35523297521bb18b075ed582639991e8b1d
--- /dev/null
+++ b/webrtc/call/rtp_transport_controller_receive_interface.h
@@ -0,0 +1,39 @@
+/*
+ * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ */
+#ifndef WEBRTC_CALL_RTP_TRANSPORT_CONTROLLER_RECEIVE_INTERFACE_H_
+#define WEBRTC_CALL_RTP_TRANSPORT_CONTROLLER_RECEIVE_INTERFACE_H_
+
+#include <memory>
+
+#include "webrtc/call/rtp_demuxer.h"
+
+namespace webrtc {
+
+class RtpTransportReceiver {
danilchap 2017/05/23 12:53:09 Add documentation for this class. e.g. TODOs what
nisse-webrtc 2017/05/29 13:35:50 Done.
+ public:
+ virtual ~RtpTransportReceiver() {}
+};
+
+// This class acts as a factory for RtpTransportReceive objects.
+class RtpTransportControllerReceiveInterface {
+ public:
+ virtual ~RtpTransportControllerReceiveInterface() {}
+
+ virtual std::unique_ptr<RtpTransportReceiver> CreateReceiver(
+ uint32_t ssrc,
+ RtpPacketSinkInterface* sink) = 0;
+ // For registering additional sinks, needed for FlexFEC.
+ virtual void AddSink(uint32_t ssrc, RtpPacketSinkInterface* sink) = 0;
danilchap 2017/05/23 12:53:10 shouldn't flexfec call CreateReceiver for each med
nisse-webrtc 2017/05/23 14:33:09 I thought so too at first. But that will probably
danilchap 2017/05/23 16:02:02 another way: CreateReceiver might take not one ssr
+ virtual size_t RemoveSink(const RtpPacketSinkInterface* sink) = 0;
danilchap 2017/05/23 12:53:10 Should this function be in this interface? May be
nisse-webrtc 2017/05/23 14:33:09 Only for symmetry with AddSink, which seems needed
+};
+
+} // namespace webrtc
+
+#endif // WEBRTC_CALL_RTP_TRANSPORT_CONTROLLER_RECEIVE_INTERFACE_H_

Powered by Google App Engine
This is Rietveld 408576698