Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Side by Side Diff: webrtc/call/rtp_transport_controller_receive_interface.h

Issue 2886993005: Introduce RtpStreamReceiver and RtpStreamReceiverControllerInterface. (Closed)
Patch Set: Fix FlexFEC. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 /*
2 * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10 #ifndef WEBRTC_CALL_RTP_TRANSPORT_CONTROLLER_RECEIVE_INTERFACE_H_
11 #define WEBRTC_CALL_RTP_TRANSPORT_CONTROLLER_RECEIVE_INTERFACE_H_
12
13 #include <memory>
14
15 #include "webrtc/call/rtp_demuxer.h"
16
17 namespace webrtc {
18
19 class RtpTransportReceiver {
danilchap 2017/05/23 12:53:09 Add documentation for this class. e.g. TODOs what
nisse-webrtc 2017/05/29 13:35:50 Done.
20 public:
21 virtual ~RtpTransportReceiver() {}
22 };
23
24 // This class acts as a factory for RtpTransportReceive objects.
25 class RtpTransportControllerReceiveInterface {
26 public:
27 virtual ~RtpTransportControllerReceiveInterface() {}
28
29 virtual std::unique_ptr<RtpTransportReceiver> CreateReceiver(
30 uint32_t ssrc,
31 RtpPacketSinkInterface* sink) = 0;
32 // For registering additional sinks, needed for FlexFEC.
33 virtual void AddSink(uint32_t ssrc, RtpPacketSinkInterface* sink) = 0;
danilchap 2017/05/23 12:53:10 shouldn't flexfec call CreateReceiver for each med
nisse-webrtc 2017/05/23 14:33:09 I thought so too at first. But that will probably
danilchap 2017/05/23 16:02:02 another way: CreateReceiver might take not one ssr
34 virtual size_t RemoveSink(const RtpPacketSinkInterface* sink) = 0;
danilchap 2017/05/23 12:53:10 Should this function be in this interface? May be
nisse-webrtc 2017/05/23 14:33:09 Only for symmetry with AddSink, which seems needed
35 };
36
37 } // namespace webrtc
38
39 #endif // WEBRTC_CALL_RTP_TRANSPORT_CONTROLLER_RECEIVE_INTERFACE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698