Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2886713002: Tracking rbe tools with a GN target (Closed)

Created:
3 years, 7 months ago by mbonadei
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Tracking rbe tools with a GN target Files under the tools directory were untracked by GN. This cl creates a target for them. The target is testonly because it depends on "webrtc/test:rtp_test_utils". BUG=webrtc:7651 NOTRY=True Review-Url: https://codereview.webrtc.org/2886713002 Cr-Commit-Position: refs/heads/master@{#19683} Committed: https://chromium.googlesource.com/external/webrtc/+/2877eaf7fe2759b5464596ceca4e8f640f809a16

Patch Set 1 #

Patch Set 2 : Adding gflags dep to remote_bitrate_estimator_tools #

Patch Set 3 : Suppress warnings from the Chromium Clang plugin #

Patch Set 4 : Skip build of remote_bitrate_estimator_tools in chromium #

Patch Set 5 : Rebasing and fixing conflicts/errors #

Patch Set 6 : Fixing trybots #

Patch Set 7 : Fixing trybots (take 2) #

Patch Set 8 : Avoiding to build bwe_rtp_play and rtp_to_text #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M webrtc/modules/remote_bitrate_estimator/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +20 lines, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/tools/bwe_rtp.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (11 generated)
mbonadei
3 years, 7 months ago (2017-05-16 09:49:13 UTC) #2
phoglund
Ping Björn, Åsa
3 years, 3 months ago (2017-09-04 07:22:26 UTC) #5
mbonadei
On 2017/09/04 07:22:26, phoglund_ooo_parental_leave wrote: > Ping Björn, Åsa Thanks Patrik, I forgot about this! ...
3 years, 3 months ago (2017-09-04 07:42:29 UTC) #6
terelius
lgtm
3 years, 3 months ago (2017-09-05 07:00:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2886713002/160001
3 years, 3 months ago (2017-09-05 07:44:12 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/27515)
3 years, 3 months ago (2017-09-05 08:31:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2886713002/160001
3 years, 3 months ago (2017-09-05 09:58:52 UTC) #16
commit-bot: I haz the power
3 years, 3 months ago (2017-09-05 10:01:51 UTC) #19
Message was sent while issue was closed.
Committed patchset #8 (id:160001) as
https://chromium.googlesource.com/external/webrtc/+/2877eaf7fe2759b5464596cec...

Powered by Google App Engine
This is Rietveld 408576698