Fixing memory leak of generated session descriptions on Android.

Fixing memory leak of generated session descriptions on Android.

SessionDescriptionObserver::OnSuccess takes ownership of the
description, but it doesn't use a unique_ptr, so the JNI code was
neglecting to delete it.

BUG=webrtc:7680
Review-Url: https://codereview.webrtc.org/2886263003
Cr-Commit-Position: refs/heads/master@{#18200}
Committed: https://chromium.googlesource.com/external/webrtc/+/119c40784872c2d8ac78469bfa39044b9c4a5502

[Taylor Brandstetter, 2017-05-17 22:25:51]

deadbeef@webrtc.org changed reviewers:
+ sakal@webrtc.org

[Taylor Brandstetter, 2017-05-17 22:25:52]

PTAL

[sakal, 2017-05-18 12:37:08]

Did this cause any practical problems? If so, I think we should create a bug so
this is mentioned in release notes.

lgtm

[Taylor Brandstetter, 2017-05-18 15:29:32]

Description was changed from

==========
Fixing memory leak of generated session descriptions on Android.

SessionDescriptionObserver::OnSuccess takes ownership of the
description, but it doesn't use a unique_ptr, so the JNI code was
neglecting to delete it.

BUG=None
==========

to

==========
Fixing memory leak of generated session descriptions on Android.

SessionDescriptionObserver::OnSuccess takes ownership of the
description, but it doesn't use a unique_ptr, so the JNI code was
neglecting to delete it.

BUG=webrtc:7680
==========

[Taylor Brandstetter, 2017-05-18 15:29:46]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2017-05-18 15:29:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-18 15:45:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495121386308990, "parent_rev":
"3184f8e3293e8b1e4afc314e7e7ba2a24060a5df", "commit_rev":
"119c40784872c2d8ac78469bfa39044b9c4a5502"}

[commit-bot: I haz the power, 2017-05-18 15:46:03]

Description was changed from

==========
Fixing memory leak of generated session descriptions on Android.

SessionDescriptionObserver::OnSuccess takes ownership of the
description, but it doesn't use a unique_ptr, so the JNI code was
neglecting to delete it.

BUG=webrtc:7680
==========

to

==========
Fixing memory leak of generated session descriptions on Android.

SessionDescriptionObserver::OnSuccess takes ownership of the
description, but it doesn't use a unique_ptr, so the JNI code was
neglecting to delete it.

BUG=webrtc:7680

Review-Url: https://codereview.webrtc.org/2886263003
Cr-Commit-Position: refs/heads/master@{#18200}
Committed:
https://chromium.googlesource.com/external/webrtc/+/119c40784872c2d8ac78469bf...
==========

[commit-bot: I haz the power, 2017-05-18 15:46:04]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/119c40784872c2d8ac78469bf...