Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2886183002:
Updated comments for unit tests to validate iOS audio session isInterrupted flag does not get reset… (Closed)
|
Created:
3 years, 7 months ago by jtt_webrtc Modified:
3 years, 7 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionUpdated comments for unit tests to validate iOS audio session isInterrupted flag does not get reset correctly.
BUG=webrtc:7605
Review-Url: https://codereview.webrtc.org/2886183002
Cr-Commit-Position: refs/heads/master@{#18188}
Committed: https://chromium.googlesource.com/external/webrtc/+/855aeead578e77560cd0d29559fd747d3ae406a4
Patch Set 1 #
Total comments: 1
Patch Set 2 : Updated comments #
Total comments: 2
Patch Set 3 : fixed typo #Messages
Total messages: 19 (10 generated)
Description was changed from ========== Updated comments for unit tests to validate iOS audio session isInterrupted flag does not get reset correctly. ========== to ========== Updated comments for unit tests to validate iOS audio session isInterrupted flag does not get reset correctly. BUG=webrtc:7605 ==========
jtteh@webrtc.org changed reviewers: + henrika@webrtc.org, tkchin@webrtc.org
Had to create a new CL to update the comments.
https://codereview.webrtc.org/2886183002/diff/1/webrtc/modules/audio_device/i... File webrtc/modules/audio_device/ios/audio_device_unittest_ios.mm (right): https://codereview.webrtc.org/2886183002/diff/1/webrtc/modules/audio_device/i... webrtc/modules/audio_device/ios/audio_device_unittest_ios.mm:828: // Verifies that the AudioDeviceIOS is_interrupted_ flag is reset correctly I think this needs some information about when AudioDeviceIOS subscribes to notifications from RTCAudioSession. It's not so much that RTCAudioSession can't notify the audio device - it's that the audio device is choosing not to listen when playback or recording is not set up.
On 2017/05/17 18:15:27, tkchin_webrtc wrote: > https://codereview.webrtc.org/2886183002/diff/1/webrtc/modules/audio_device/i... > File webrtc/modules/audio_device/ios/audio_device_unittest_ios.mm (right): > > https://codereview.webrtc.org/2886183002/diff/1/webrtc/modules/audio_device/i... > webrtc/modules/audio_device/ios/audio_device_unittest_ios.mm:828: // Verifies > that the AudioDeviceIOS is_interrupted_ flag is reset correctly > I think this needs some information about when AudioDeviceIOS subscribes to > notifications from RTCAudioSession. > > It's not so much that RTCAudioSession can't notify the audio device - it's that > the audio device is choosing not to listen when playback or recording is not set > up. Rewrote comments.
Rewrote comments.
lgtm https://codereview.webrtc.org/2886183002/diff/20001/webrtc/modules/audio_devi... File webrtc/modules/audio_device/ios/audio_device_unittest_ios.mm (right): https://codereview.webrtc.org/2886183002/diff/20001/webrtc/modules/audio_devi... webrtc/modules/audio_device/ios/audio_device_unittest_ios.mm:834: // passes the notifcation to callbacks in its delegate list which sets nit: typo https://codereview.webrtc.org/2886183002/diff/20001/webrtc/modules/audio_devi... webrtc/modules/audio_device/ios/audio_device_unittest_ios.mm:840: // AudioDeviceIOS is not notified as it's callback is not in RTCAudioSession's nit: its
The CQ bit was checked by jtteh@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
On 2017/05/17 18:44:39, tkchin_webrtc wrote: > lgtm > > https://codereview.webrtc.org/2886183002/diff/20001/webrtc/modules/audio_devi... > File webrtc/modules/audio_device/ios/audio_device_unittest_ios.mm (right): > > https://codereview.webrtc.org/2886183002/diff/20001/webrtc/modules/audio_devi... > webrtc/modules/audio_device/ios/audio_device_unittest_ios.mm:834: // passes > the notifcation to callbacks in its delegate list which sets > nit: typo > > https://codereview.webrtc.org/2886183002/diff/20001/webrtc/modules/audio_devi... > webrtc/modules/audio_device/ios/audio_device_unittest_ios.mm:840: // > AudioDeviceIOS is not notified as it's callback is not in RTCAudioSession's > nit: its Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jtteh@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from tkchin@webrtc.org Link to the patchset: https://codereview.webrtc.org/2886183002/#ps40001 (title: "fixed typo")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495049684715890,
"parent_rev": "8c96a148a871a9d0be5cdcf2e548b2f9658f2542", "commit_rev":
"855aeead578e77560cd0d29559fd747d3ae406a4"}
Message was sent while issue was closed.
Description was changed from ========== Updated comments for unit tests to validate iOS audio session isInterrupted flag does not get reset correctly. BUG=webrtc:7605 ========== to ========== Updated comments for unit tests to validate iOS audio session isInterrupted flag does not get reset correctly. BUG=webrtc:7605 Review-Url: https://codereview.webrtc.org/2886183002 Cr-Commit-Position: refs/heads/master@{#18188} Committed: https://chromium.googlesource.com/external/webrtc/+/855aeead578e77560cd0d2955... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/external/webrtc/+/855aeead578e77560cd0d2955...
Message was sent while issue was closed.
lgtm |
