Delete class NullRtpData and function NullObjectRtpData

Delete class NullRtpData and function NullObjectRtpData.

BUG=webrtc:5565
Review-Url: https://codereview.webrtc.org/2885823002
Cr-Commit-Position: refs/heads/master@{#18366}
Committed: https://chromium.googlesource.com/external/webrtc/+/7fcdb6d7ca94147cc607e3e025ac8ff6bf402878

[nisse-webrtc, 2017-05-31 12:38:34]

nisse@webrtc.org changed reviewers:
+ danilchap@webrtc.org

[nisse-webrtc, 2017-05-31 12:38:35]

Hi, I would like to delete NullRtpData. With this version of the cl, it's used
in two places: RtpReceiverTest, and RtpRtcpAPITest. For the former, it would
probably make sense to use a MockRtpData instead, and check that it is called as
expected. For the latter, it calls RtpReceiver::CreateAudioReceiver, but the
result appear unused, so maybe it can just be deleted?

[danilchap, 2017-05-31 12:58:50]

On 2017/05/31 12:38:35, nisse-webrtc wrote:
> Hi, I would like to delete NullRtpData. With this version of the cl, it's used
> in two places: RtpReceiverTest, and RtpRtcpAPITest. For the former, it would
> probably make sense to use a MockRtpData instead, and check that it is called
as
> expected. For the latter, it calls RtpReceiver::CreateAudioReceiver, but the
> result appear unused, so maybe it can just be deleted?
lgtm

This CL looks like a good 2nd step in deleting it (1st step was removing a
function in RtpData interface - seems some classes were derived from NullRtpData
just for the OnRecoveredPacket implementation),

both for rtpreceiverTest and rtprtcpapiTest it would make sense to use
MockRtpData instead.
For now, to keep current behavior, NiceMock<MockRtpData>.
Later, would make sense to refactor tests and actually expect something from the
Mock.

[danilchap, 2017-05-31 12:59:29]

https://codereview.webrtc.org/2885823002/diff/80001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc (right):

https://codereview.webrtc.org/2885823002/diff/80001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc:91: int
OnReceivedPayloadData(const uint8_t* payload_data,
return type is int32_t

[danilchap, 2017-05-31 13:01:45]

btw, feel free to use BUG=webrtc:5565 for these CLs

[nisse-webrtc, 2017-05-31 13:08:34]

Description was changed from

==========
Delete NullObjectRtpData.

BUG=None
==========

to

==========
Delete NullObjectRtpData.

BUG=webrtc:5565
==========

[nisse-webrtc, 2017-05-31 13:24:03]

On 2017/05/31 12:58:50, danilchap wrote:

> both for rtpreceiverTest and rtprtcpapiTest it would make sense to use
> MockRtpData instead.

Done (this class already existed).

But I'd prefer to land https://codereview.webrtc.org/2912363002/ first.

[nisse-webrtc, 2017-05-31 13:24:13]

https://codereview.webrtc.org/2885823002/diff/80001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc (right):

https://codereview.webrtc.org/2885823002/diff/80001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc:91: int
OnReceivedPayloadData(const uint8_t* payload_data,
On 2017/05/31 12:59:28, danilchap wrote:
> return type is int32_t

Done.

[nisse-webrtc, 2017-05-31 13:25:17]

Description was changed from

==========
Delete NullObjectRtpData.

BUG=webrtc:5565
==========

to

==========
Delete class NullRtpData and function NullObjectRtpData.

BUG=webrtc:5565
==========

[nisse-webrtc, 2017-05-31 14:43:30]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 14:43:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[nisse-webrtc, 2017-05-31 14:44:07]

Do you want to take another look after the rebase?

[danilchap, 2017-05-31 14:57:33]

It looks noticeably more than a rebase, so yes, want to take a look, and...
lgtm with an optional nit.

https://codereview.webrtc.org/2885823002/diff/140001/webrtc/modules/rtp_rtcp/...
File webrtc/modules/rtp_rtcp/source/rtp_receiver_unittest.cc (right):

https://codereview.webrtc.org/2885823002/diff/140001/webrtc/modules/rtp_rtcp/...
webrtc/modules/rtp_rtcp/source/rtp_receiver_unittest.cc:25: 
may be add here 
using ::testing::NiceMock;

https://codereview.webrtc.org/2885823002/diff/140001/webrtc/modules/rtp_rtcp/...
webrtc/modules/rtp_rtcp/source/rtp_receiver_unittest.cc:77:
::testing::NiceMock<MockRtpData> mock_rtp_data_;
to make this line look nicer

[commit-bot: I haz the power, 2017-05-31 15:10:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 15:10:54]

Dry run: This issue passed the CQ dry run.

[nisse-webrtc, 2017-06-01 06:59:56]

https://codereview.webrtc.org/2885823002/diff/140001/webrtc/modules/rtp_rtcp/...
File webrtc/modules/rtp_rtcp/source/rtp_receiver_unittest.cc (right):

https://codereview.webrtc.org/2885823002/diff/140001/webrtc/modules/rtp_rtcp/...
webrtc/modules/rtp_rtcp/source/rtp_receiver_unittest.cc:77:
::testing::NiceMock<MockRtpData> mock_rtp_data_;
On 2017/05/31 14:57:33, danilchap wrote:
> to make this line look nicer

Done.

[nisse-webrtc, 2017-06-01 07:00:22]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2017-06-01 07:00:23]

The patchset sent to the CQ was uploaded after l-g-t-m from danilchap@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2885823002/#ps160001 (title:
"Add using declaration.")

[commit-bot: I haz the power, 2017-06-01 07:00:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-01 07:30:56]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1496300422895650,
"parent_rev": "a0bf559b52ec3fb9589110c32955ed0f6539b8c4", "commit_rev":
"7fcdb6d7ca94147cc607e3e025ac8ff6bf402878"}

[commit-bot: I haz the power, 2017-06-01 07:31:00]

Description was changed from

==========
Delete class NullRtpData and function NullObjectRtpData.

BUG=webrtc:5565
==========

to

==========
Delete class NullRtpData and function NullObjectRtpData.

BUG=webrtc:5565

Review-Url: https://codereview.webrtc.org/2885823002
Cr-Commit-Position: refs/heads/master@{#18366}
Committed:
https://chromium.googlesource.com/external/webrtc/+/7fcdb6d7ca94147cc607e3e02...
==========

[commit-bot: I haz the power, 2017-06-01 07:31:01]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/external/webrtc/+/7fcdb6d7ca94147cc607e3e02...