Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: webrtc/sdk/android/api/org/webrtc/EglBase.java

Issue 2885163003: Allow constructing an EglBase from an existing shared EGLContext. (Closed)
Patch Set: Use name "sharedContext", as it's used elsewhere. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/sdk/android/api/org/webrtc/EglBase.java
diff --git a/webrtc/sdk/android/api/org/webrtc/EglBase.java b/webrtc/sdk/android/api/org/webrtc/EglBase.java
index 3e221c2f478d368cca0f1c3534dc15df8c55b740..9a2badeac4545f4f0f44175797026c87fc66ad7e 100644
--- a/webrtc/sdk/android/api/org/webrtc/EglBase.java
+++ b/webrtc/sdk/android/api/org/webrtc/EglBase.java
@@ -116,12 +116,30 @@ public abstract class EglBase {
}
/**
+ * Explicitly create a root EGl 1.0 context with the specified config attributes
+ * and shader context.
magjed_webrtc 2017/05/25 14:25:19 nit: shared, not shader.
Taylor Brandstetter 2017/05/25 16:53:57 Done; I saw "shaderContext" used in another place
+ */
+ public static EglBase createEgl10(
+ javax.microedition.khronos.egl.EGLContext sharedContext, int[] configAttributes) {
+ return new EglBase10(new EglBase10.Context(sharedContext), configAttributes);
+ }
+
+ /**
* Explicitly create a root EGl 1.4 context with the specified config attributes.
*/
public static EglBase createEgl14(int[] configAttributes) {
return new EglBase14(null /* shaderContext */, configAttributes);
}
+ /**
+ * Explicitly create a root EGl 1.4 context with the specified config attributes
+ * and shader context.
magjed_webrtc 2017/05/25 14:25:19 nit: shared, not shader.
+ */
+ public static EglBase createEgl14(
+ android.opengl.EGLContext sharedContext, int[] configAttributes) {
+ return new EglBase14(new EglBase14.Context(sharedContext), configAttributes);
+ }
+
public abstract void createSurface(Surface surface);
// Create EGLSurface from the Android SurfaceTexture.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698