Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 2884913002: Ensures the residual echo detector does not requiring band-splitting (Closed)

Created:
3 years, 7 months ago by peah-webrtc
Modified:
3 years, 7 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Ensures the residual echo detector does not requiring band-splitting This CL removes the residual echo detector from the list of modules in APM that requires band-splitting. BUG=webrtc:6220, webrtc:6183 Review-Url: https://codereview.webrtc.org/2884913002 Cr-Commit-Position: refs/heads/master@{#18164} Committed: https://chromium.googlesource.com/external/webrtc/+/52775841f0212b0a61ec17ac86080ccbb1c19812

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M webrtc/modules/audio_processing/audio_processing_impl.cc View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
peah-webrtc
Hi, Could you please take a look at this CL? It should have been part ...
3 years, 7 months ago (2017-05-16 08:26:26 UTC) #3
ivoc
Good catch, lgtm.
3 years, 7 months ago (2017-05-16 09:32:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2884913002/1
3 years, 7 months ago (2017-05-16 12:44:18 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 13:14:15 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/52775841f0212b0a61ec17ac8...

Powered by Google App Engine
This is Rietveld 408576698