Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1126)

Issue 2884643004: Add traces for some video receive statistics. (Closed)

Created:
3 years, 7 months ago by ehmaldonado_webrtc
Modified:
3 years, 7 months ago
Reviewers:
tommi, åsapersson
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add traces for some video receive statistics. This CL adds traces to compute the following metrics that getStats() captures for video: - googFrameRateOutput - packetsLost - googFrameWidthReceived - googFrameHeightReceived - googCurrentDelayMs - googTargetDelayMs - googDecodeMs - googMaxDecodeMs - googJitterBufferMs - googRenderDelayMs BUG=chromium:653087 Review-Url: https://codereview.webrtc.org/2884643004 Cr-Commit-Position: refs/heads/master@{#18242} Committed: https://chromium.googlesource.com/external/webrtc/+/c1b5ea959ed058c7b44c437f1cbbbccf6d9daf6c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M webrtc/video/receive_statistics_proxy.cc View 4 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
ehmaldonado_webrtc
PTAL :)
3 years, 7 months ago (2017-05-16 10:45:38 UTC) #3
åsapersson
lgtm
3 years, 7 months ago (2017-05-19 07:20:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2884643004/20001
3 years, 7 months ago (2017-05-23 15:40:42 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 16:06:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/c1b5ea959ed058c7b44c437f1...

Powered by Google App Engine
This is Rietveld 408576698