Moving the residual echo detector outside of band-scheme in APM

Moving the residual echo detector outside of band-scheme in APM

This CL moves the residual echo detector to reside outside of
the band-scheme in APM. The benefit of this is that the 
residual echo detector will then no longer enforce the 
band-splitting to be used when it is the only active component
inside APM.

This CL also introduces diagnostic dumping of data inside the
residual echo detector.

BUG=webrtc:6220, webrtc:6183
Review-Url: https://codereview.webrtc.org/2884593002
Cr-Commit-Position: refs/heads/master@{#18150}
Committed: https://chromium.googlesource.com/external/webrtc/+/9e6a290c8d6978f9294c5b0b8bde9244dfe04997

[peah-webrtc, 2017-05-15 07:17:42]

Description was changed from

==========
Moving residualechodetector outside of band-scheme

Added dumping of data


Added dumping of data


Should work


Should work

BUG=
==========

to

==========
Moving the residual echo detector outside of band-scheme in APM

This CL moves the residual echo detector to reside outside of
the band-scheme in APM. The benefit of this is that the 
residual echo detector will then no longer enforce the 
band-splitting to be used when it is the only active component
inside APM.

This CL also introduces diagnostic dumping of data inside the
residual echo detector.

BUG=webrtc:6220, webrtc:6183
==========

[peah-webrtc, 2017-05-15 07:18:15]

peah@webrtc.org changed reviewers:
+ ivoc@webrtc.org

[peah-webrtc, 2017-05-15 07:18:16]

Hi,
Could you please take a look at this CL?

[ivoc, 2017-05-15 13:16:30]

Very nice, LGTM, that was simpler than I thought it would be.

[peah-webrtc, 2017-05-15 13:30:08]

The CQ bit was checked by peah@webrtc.org

[commit-bot: I haz the power, 2017-05-15 13:30:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-15 14:19:22]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494855008071010, "parent_rev":
"56f8783f36705d0241f22d6dd204e3d1e62dd8b5", "commit_rev":
"9e6a290c8d6978f9294c5b0b8bde9244dfe04997"}

[commit-bot: I haz the power, 2017-05-15 14:19:26]

Description was changed from

==========
Moving the residual echo detector outside of band-scheme in APM

This CL moves the residual echo detector to reside outside of
the band-scheme in APM. The benefit of this is that the 
residual echo detector will then no longer enforce the 
band-splitting to be used when it is the only active component
inside APM.

This CL also introduces diagnostic dumping of data inside the
residual echo detector.

BUG=webrtc:6220, webrtc:6183
==========

to

==========
Moving the residual echo detector outside of band-scheme in APM

This CL moves the residual echo detector to reside outside of
the band-scheme in APM. The benefit of this is that the 
residual echo detector will then no longer enforce the 
band-splitting to be used when it is the only active component
inside APM.

This CL also introduces diagnostic dumping of data inside the
residual echo detector.

BUG=webrtc:6220, webrtc:6183

Review-Url: https://codereview.webrtc.org/2884593002
Cr-Commit-Position: refs/heads/master@{#18150}
Committed:
https://chromium.googlesource.com/external/webrtc/+/9e6a290c8d6978f9294c5b0b8...
==========

[commit-bot: I haz the power, 2017-05-15 14:19:27]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/9e6a290c8d6978f9294c5b0b8...