Add media related stats (audio level etc.) to unsignaled streams.

Add media related stats (audio level etc.) to unsignaled streams.

The media related stats wasn't working for unsignaled stream because there
is no mapping between the receiver_info and unsignaled tracks.

This CL fixes the issue by adding some special logic to the TrackMediaInfoMap
which would create the mapping.

BUG=b/37836881
BUG=webrtc:7685
TBR=deadbeef@webrtc.org

Review-Url: https://codereview.webrtc.org/2883943003
Cr-Commit-Position: refs/heads/master@{#18217}
Committed: https://chromium.googlesource.com/external/webrtc/+/f816493c4f6b016b66ef40fb6b9f59f71ed8c8ea

[Zhi Huang, 2017-05-15 21:20:37]

zhihuang@webrtc.org changed reviewers:
+ deadbeef@webrtc.org

[Zhi Huang, 2017-05-15 21:20:38]

Please take a look. Thanks.

[Taylor Brandstetter, 2017-05-17 01:30:04]

lgtm with minor comments. Also, could you create a bug in the open-source bug
repo?

https://codereview.webrtc.org/2883943003/diff/1/webrtc/pc/peerconnection_inte...
File webrtc/pc/peerconnection_integrationtest.cc (right):

https://codereview.webrtc.org/2883943003/diff/1/webrtc/pc/peerconnection_inte...
webrtc/pc/peerconnection_integrationtest.cc:1935: // received stream stats in
TrackMediaInfoMap.
Can this TODO be fixed in this CL?

https://codereview.webrtc.org/2883943003/diff/1/webrtc/pc/peerconnection_inte...
webrtc/pc/peerconnection_integrationtest.cc:1958:
EXPECT_TRUE(media_stats[0]->audio_level.is_defined());
This relies on media_stats[0] being the audio track and not the video track,
which I don't think is guaranteed anywhere. Would be better to explicitly find
the one with a "kind"
(https://cs.chromium.org/chromium/src/third_party/webrtc/api/stats/rtcstats_ob...)
of "audio".

[Zhi Huang, 2017-05-19 19:33:17]

Description was changed from

==========
Add media related stats (audio level etc.) to unsignaled streams.

The media related stats wasn't working for unsignaled stream because there
is no mapping between the receiver_info and unsignaled tracks.

This CL fixes the issue by adding some special logic to the TrackMediaInfoMap
which would create the mapping.

BUG=b/37836881
==========

to

==========
Add media related stats (audio level etc.) to unsignaled streams.

The media related stats wasn't working for unsignaled stream because there
is no mapping between the receiver_info and unsignaled tracks.

This CL fixes the issue by adding some special logic to the TrackMediaInfoMap
which would create the mapping.

BUG=b/37836881
BUG=webrtc:7685
==========

[Zhi Huang, 2017-05-19 19:45:43]

Patchset #2 (id:20001) has been deleted

[Zhi Huang, 2017-05-19 19:48:42]

Description was changed from

==========
Add media related stats (audio level etc.) to unsignaled streams.

The media related stats wasn't working for unsignaled stream because there
is no mapping between the receiver_info and unsignaled tracks.

This CL fixes the issue by adding some special logic to the TrackMediaInfoMap
which would create the mapping.

BUG=b/37836881
BUG=webrtc:7685
==========

to

==========
Add media related stats (audio level etc.) to unsignaled streams.

The media related stats wasn't working for unsignaled stream because there
is no mapping between the receiver_info and unsignaled tracks.

This CL fixes the issue by adding some special logic to the TrackMediaInfoMap
which would create the mapping.

BUG=b/37836881
BUG=webrtc:7685

TBR=deadbeef@webrtc.org
==========

[Zhi Huang, 2017-05-19 19:48:47]

The CQ bit was checked by zhihuang@webrtc.org

[Zhi Huang, 2017-05-19 19:48:47]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2883943003/#ps40001 (title:
"Fix the bug related to the unsignaled video track. Modified the test.")

[commit-bot: I haz the power, 2017-05-19 19:48:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-19 20:09:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495223327275460,
"parent_rev": "56e119e2e8b30d2d41c55c3a7983b077a5262718", "commit_rev":
"f816493c4f6b016b66ef40fb6b9f59f71ed8c8ea"}

[commit-bot: I haz the power, 2017-05-19 20:09:53]

Description was changed from

==========
Add media related stats (audio level etc.) to unsignaled streams.

The media related stats wasn't working for unsignaled stream because there
is no mapping between the receiver_info and unsignaled tracks.

This CL fixes the issue by adding some special logic to the TrackMediaInfoMap
which would create the mapping.

BUG=b/37836881
BUG=webrtc:7685

TBR=deadbeef@webrtc.org
==========

to

==========
Add media related stats (audio level etc.) to unsignaled streams.

The media related stats wasn't working for unsignaled stream because there
is no mapping between the receiver_info and unsignaled tracks.

This CL fixes the issue by adding some special logic to the TrackMediaInfoMap
which would create the mapping.

BUG=b/37836881
BUG=webrtc:7685

TBR=deadbeef@webrtc.org

Review-Url: https://codereview.webrtc.org/2883943003
Cr-Commit-Position: refs/heads/master@{#18217}
Committed:
https://chromium.googlesource.com/external/webrtc/+/f816493c4f6b016b66ef40fb6...
==========

[commit-bot: I haz the power, 2017-05-19 20:09:54]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/f816493c4f6b016b66ef40fb6...