Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2883833003: Autoroller: Skip commit if there are no DEPS changes. (Closed)

Created:
3 years, 7 months ago by kjellander_webrtc
Modified:
3 years, 7 months ago
Reviewers:
mbonadei
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Autoroller: Skip commit if there are no DEPS changes. This will avoid failing with a non-zero exit code when git commit fails due to no changes to be rolled. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/2883833003 Cr-Commit-Position: refs/heads/master@{#18146} Committed: https://chromium.googlesource.com/external/webrtc/+/c99bddfc1c38c67f709d821bc82ba21a9c889165

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M tools_webrtc/autoroller/roll_deps.py View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
kjellander_webrtc
3 years, 7 months ago (2017-05-15 05:49:18 UTC) #3
mbonadei
On 2017/05/15 05:49:18, kjellander_webrtc wrote: lgtm
3 years, 7 months ago (2017-05-15 06:57:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2883833003/1
3 years, 7 months ago (2017-05-15 09:38:27 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 09:41:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/c99bddfc1c38c67f709d821bc...

Powered by Google App Engine
This is Rietveld 408576698