Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2883033002: Adding target to track asm_defines.h (Closed)

Created:
3 years, 7 months ago by mbonadei
Modified:
3 years, 7 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, zhengzhonghou_agora.io, tterriberry_mozilla.com, fengyue_agora.io, peah-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding target to track asm_defines.h This header is only included by .S files and they are not parsed by GN, so no other changes are required. BUG=webrtc:7617 Review-Url: https://codereview.webrtc.org/2883033002 Cr-Commit-Position: refs/heads/master@{#18154} Committed: https://chromium.googlesource.com/external/webrtc/+/b1d6b54946e80fad2651d7ed7f5532260c6f3c17

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M webrtc/system_wrappers/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mbonadei
3 years, 7 months ago (2017-05-15 15:17:52 UTC) #2
kwiberg-webrtc
Yup---the only point of this target is so that we don't have to have exceptions ...
3 years, 7 months ago (2017-05-15 16:45:26 UTC) #3
mbonadei
On 2017/05/15 16:45:26, kwiberg-webrtc wrote: > Yup---the only point of this target is so that ...
3 years, 7 months ago (2017-05-15 21:34:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2883033002/1
3 years, 7 months ago (2017-05-15 21:35:25 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 21:59:24 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/b1d6b54946e80fad2651d7ed7...

Powered by Google App Engine
This is Rietveld 408576698