Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2882673002: Moving compile_assert_c.h to webrtc/base (Closed)

Created:
3 years, 7 months ago by mbonadei
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, zhengzhonghou_agora.io, fengyue_agora.io, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, henrika_webrtc, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Moving compile_assert_c.h to webrtc/base This header was not tracked by a GN target and in the discussion on https://bugs.chromium.org/p/webrtc/issues/detail?id=7617 we decided to also move it under webrtc/base. I checked in chromium code search and it seems safe to move it without creating a stub header in webrtc/system_wrappers. BUG=webrtc:7617 Review-Url: https://codereview.webrtc.org/2882673002 Cr-Commit-Position: refs/heads/master@{#18151} Committed: https://chromium.googlesource.com/external/webrtc/+/9baa77981f733a98e764171c90685f1985b3d470

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -30 lines) Patch
M webrtc/base/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
A + webrtc/base/compile_assert_c.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/common_audio/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/common_audio/signal_processing/include/spl_inl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/source/pitch_estimator.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/source/pitch_estimator_c.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/source/pitch_estimator_mips.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/source/pitch_filter.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/source/pitch_filter.c View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/system_wrappers/include/compile_assert_c.h View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mbonadei
Adding mflodman@ as owner of both webrtc/base and webrtc/system_wrappers; kwiberg@ for the advice on https://bugs.chromium.org/p/webrtc/issues/detail?id=7617.
3 years, 7 months ago (2017-05-12 13:10:58 UTC) #2
kwiberg-webrtc
lgtm (I OWN enough stuff that mflodman won't have to review this unless he wants ...
3 years, 7 months ago (2017-05-12 13:37:45 UTC) #3
mflodman
I'll happily trust your review in this case Karl!
3 years, 7 months ago (2017-05-15 08:52:37 UTC) #4
mflodman
On 2017/05/15 08:52:37, mflodman wrote: > I'll happily trust your review in this case Karl! ...
3 years, 7 months ago (2017-05-15 08:53:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2882673002/1
3 years, 7 months ago (2017-05-15 14:38:40 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 15:06:57 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/9baa77981f733a98e764171c9...

Powered by Google App Engine
This is Rietveld 408576698