Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2881973002: Get tests working on systems that only support IPv6. (Closed)

Created:
3 years, 7 months ago by Taylor Brandstetter
Modified:
3 years, 7 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Get tests working on systems that only support IPv6. For every failing test, the solution was either to do a "has IPv4" check before the test is run, or avoid depending on real network interfaces altogether. This specifically fixes rtc_unittests, peerconnection_unittests, and webrtc_nonparallel_tests. BUG=None Review-Url: https://codereview.webrtc.org/2881973002 Cr-Commit-Position: refs/heads/master@{#18155} Committed: https://chromium.googlesource.com/external/webrtc/+/9a6f4d4316af2307ac6699525559ecea3500f75f

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -20 lines) Patch
M webrtc/base/nethelpers.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/nethelpers.cc View 1 chunk +20 lines, -0 lines 1 comment Download
M webrtc/base/physicalsocketserver_unittest.cc View 22 chunks +27 lines, -0 lines 0 comments Download
M webrtc/base/testclient_unittest.cc View 4 chunks +18 lines, -10 lines 0 comments Download
M webrtc/p2p/base/portallocator_unittest.cc View 3 chunks +9 lines, -1 line 0 comments Download
M webrtc/p2p/base/stunport_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/client/basicportallocator_unittest.cc View 3 chunks +17 lines, -7 lines 0 comments Download
M webrtc/p2p/stunprober/stunprober.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/p2p/stunprober/stunprober.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M webrtc/pc/peerconnectioninterface_unittest.cc View 3 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Taylor Brandstetter
PTAL.
3 years, 7 months ago (2017-05-13 05:12:24 UTC) #4
pthatcher1
lgtm https://codereview.webrtc.org/2881973002/diff/1/webrtc/base/nethelpers.cc File webrtc/base/nethelpers.cc (right): https://codereview.webrtc.org/2881973002/diff/1/webrtc/base/nethelpers.cc#newcode154 webrtc/base/nethelpers.cc:154: break; Why not just "freeifaddrs(ifa); return true;"?
3 years, 7 months ago (2017-05-15 21:50:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2881973002/1
3 years, 7 months ago (2017-05-16 02:00:29 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 02:43:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/9a6f4d4316af2307ac6699525...

Powered by Google App Engine
This is Rietveld 408576698