Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 2881343003: Tracking mock_process_thread with a GN target (Closed)

Created:
3 years, 7 months ago by mbonadei
Modified:
3 years, 4 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Tracking mock_process_thread with a GN target include/mock/mock_process_thread.h was not tracked by GN. This cl creates a target for it. The target is testonly because it depends on "webrtc/test:rtp_test_utils". This means that dependencies to this header cannot fly under the GN radar anymore. :) BUG=webrtc:7652 NOTRY=True Review-Url: https://codereview.webrtc.org/2881343003 Cr-Commit-Position: refs/heads/master@{#19234} Committed: https://chromium.googlesource.com/external/webrtc/+/5166e54a3dbcdad0da6fe726824fd50f688dd512

Patch Set 1 #

Patch Set 2 : Rebasing #

Patch Set 3 : rebasing #

Patch Set 4 : Fixing BUILD.gn file #

Patch Set 5 : Rebasing (again) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M webrtc/call/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/utility/BUILD.gn View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
M webrtc/video/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
mbonadei
3 years, 7 months ago (2017-05-16 12:45:09 UTC) #2
perkj_chrome
Wrong account?
3 years, 5 months ago (2017-07-06 07:44:57 UTC) #3
mbonadei
On 2017/07/06 07:44:57, perkj_chrome wrote: > Wrong account? You are the owner of webrtc/modules/utility. :-) ...
3 years, 5 months ago (2017-07-06 08:00:12 UTC) #4
perkj_webrtc
Changed account to webrtc. lgtm
3 years, 5 months ago (2017-07-06 08:01:57 UTC) #7
mbonadei
On 2017/07/06 08:01:57, perkj_webrtc wrote: > Changed account to webrtc. > > lgtm Oh yes... ...
3 years, 5 months ago (2017-07-06 08:27:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2881343003/20001
3 years, 5 months ago (2017-07-06 13:18:38 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_memcheck on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_memcheck/builds/9450)
3 years, 5 months ago (2017-07-06 13:48:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2881343003/80001
3 years, 4 months ago (2017-08-03 12:54:38 UTC) #17
commit-bot: I haz the power
3 years, 4 months ago (2017-08-03 12:57:19 UTC) #20
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/5166e54a3dbcdad0da6fe7268...

Powered by Google App Engine
This is Rietveld 408576698