Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2880663003: Reland of Make AudioSinkInterface::Data hold a const pointer to the audio buffer. (Closed)

Created:
3 years, 7 months ago by Zhi Huang
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Make AudioSinkInterface::Data hold a const pointer to the audio buffer. (patchset #1 id:1 of https://codereview.webrtc.org/2877013002/ ) Reason for revert: Re-land the original CL because the reverting it didn't fix the problem. Original issue's description: > Revert of Make AudioSinkInterface::Data hold a const pointer to the audio buffer. (patchset #1 id:1 of https://codereview.webrtc.org/2873803002/ ) > > Reason for revert: > Reverted because it possibly breaks the internal project. > > Original issue's description: > > Make AudioSinkInterface::Data hold a const pointer to the audio buffer. > > > > This is in preparation for https://codereview.webrtc.org/2750783004/, where > > requiring a non-const pointer for AudioSinkInterface would force an unmuting > > and zeroing of every frame. > > > > BUG=webrtc:7343 > > > > Review-Url: https://codereview.webrtc.org/2873803002 > > Cr-Commit-Position: refs/heads/master@{#18107} > > Committed: https://chromium.googlesource.com/external/webrtc/+/38605965bd68ad1e376c530883041b9c12f26d3b > > TBR=solenberg@webrtc.org,henrik.lundin@webrtc.org,yujo@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7343 > > Review-Url: https://codereview.webrtc.org/2877013002 > Cr-Commit-Position: refs/heads/master@{#18112} > Committed: https://chromium.googlesource.com/external/webrtc/+/c904634823fe3021d24116de246c95a7d7a2fb91 TBR=solenberg@webrtc.org,henrik.lundin@webrtc.org,yujo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7343 Review-Url: https://codereview.webrtc.org/2880663003 Cr-Commit-Position: refs/heads/master@{#18113} Committed: https://chromium.googlesource.com/external/webrtc/+/0acebe223864e5bd229647db4c4e45946c7eff86

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/api/call/audio_sink.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Zhi Huang
Created Reland of Make AudioSinkInterface::Data hold a const pointer to the audio buffer.
3 years, 7 months ago (2017-05-12 05:07:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2880663003/1
3 years, 7 months ago (2017-05-12 05:07:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/0acebe223864e5bd229647db4c4e45946c7eff86
3 years, 7 months ago (2017-05-12 05:07:42 UTC) #6
hlundin-webrtc
3 years, 7 months ago (2017-05-12 07:14:23 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698