Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1351)

Issue 2878673002: Support running AppRTC without a TURN ICE server (Closed)

Created:
3 years, 7 months ago by oprypin_webrtc
Modified:
3 years, 7 months ago
Reviewers:
sakal
CC:
webrtc-reviews_webrtc.org, mbonadei
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Support running AppRTC without a TURN ICE server The "ice_server_url" key is always present in AppRTC server's JSON response but may be empty if no ICE server is wanted. BUG=webrtc:7636 Review-Url: https://codereview.webrtc.org/2878673002 Cr-Commit-Position: refs/heads/master@{#18118} Committed: https://chromium.googlesource.com/external/webrtc/+/054be4c9d94757803df85239bae8a6e8531115f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/examples/androidapp/src/org/appspot/apprtc/RoomParametersFetcher.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
oprypin_webrtc
3 years, 7 months ago (2017-05-11 20:58:04 UTC) #5
sakal
lgtm
3 years, 7 months ago (2017-05-12 07:17:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2878673002/1
3 years, 7 months ago (2017-05-12 07:23:01 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 07:41:03 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/054be4c9d94757803df85239b...

Powered by Google App Engine
This is Rietveld 408576698