objc wrapper for PeerConnection::SetBitrate

webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h

Index: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h
diff --git a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h
index 13617b5520d588ad878f9eb1cb391a2387d27202..ce2df4d7f5ee568aae626aed1b50a353fa3165e2 100644
--- a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h
+++ b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h
@@ -184,6 +184,13 @@ RTC_EXPORT
            completionHandler:
     (nullable void (^)(NSError * _Nullable error))completionHandler;
 
+/** Updates bandwidth estimation parameters. Null parameters will be unchanged.
+ *  Returns true iff the parameters were successfully updated.
+ */
+- (BOOL)setBitrateToMin:(NSNumber *_Nullable)minBitrateBps

[tkchin_webrtc, 2017/08/31 21:20:48]

Could you update this with more details?

What bitrate is this? Data channel / video / audio?
Is this specific to bandwidth estimation only?
What does it mean to set the current bwe bitrate? Does that mean we are
disregarding stuff from the estimator?

Comment nit: "Nil parameters", Returns YES

also style nit: can we update the naming to not repeat "to", and make sure the
argument name matches the method name?

arg nit: use (nullable NSNumber *) instead

setBweMinBitrateBps:minBitrateBps
currentBitrateBps:currentBitrateBps
maxBitrateBps:maxBitrateBps

+              toCurrent:(NSNumber *_Nullable)currentBitrateBps
+                  toMax:(NSNumber *_Nullable)maxBitrateBps;
+
 /** Start or stop recording an Rtc EventLog. */
 - (BOOL)startRtcEventLogWithFilePath:(NSString *)filePath
                       maxSizeInBytes:(int64_t)maxSizeInBytes;