objc wrapper for PeerConnection::SetBitrate

webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h

 /*
  *  Copyright 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 166 matching lines @@
 /** Apply the supplied RTCSessionDescription as the local description. */
 - (void)setLocalDescription:(RTCSessionDescription *)sdp
           completionHandler:
     (nullable void (^)(NSError * _Nullable error))completionHandler;
 
 /** Apply the supplied RTCSessionDescription as the remote description. */
 - (void)setRemoteDescription:(RTCSessionDescription *)sdp
            completionHandler:
     (nullable void (^)(NSError * _Nullable error))completionHandler;
 
+/** Updates bandwidth estimation parameters. Null parameters will be unchanged.
+ *  Returns true iff the parameters were successfully updated.
+ */
+- (BOOL)setBitrateToMin:(NSNumber *_Nullable)minBitrateBps

[tkchin_webrtc, 2017/08/31 21:20:48]

Could you update this with more details?

What bitrate is this? Data channel / video / audio?
Is this specific to bandwidth estimation only?
What does it mean to set the current bwe bitrate? Does that mean we are
disregarding stuff from the estimator?

Comment nit: "Nil parameters", Returns YES

also style nit: can we update the naming to not repeat "to", and make sure the
argument name matches the method name?

arg nit: use (nullable NSNumber *) instead

setBweMinBitrateBps:minBitrateBps
currentBitrateBps:currentBitrateBps
maxBitrateBps:maxBitrateBps

+              toCurrent:(NSNumber *_Nullable)currentBitrateBps
+                  toMax:(NSNumber *_Nullable)maxBitrateBps;
+
 /** Start or stop recording an Rtc EventLog. */
 - (BOOL)startRtcEventLogWithFilePath:(NSString *)filePath
                       maxSizeInBytes:(int64_t)maxSizeInBytes;
 - (void)stopRtcEventLog;
 
 @end
 
 @interface RTCPeerConnection (Media)
 
 /**
@@ skipping 19 matching lines @@
  */
 - (void)statsForTrack:
     (nullable RTCMediaStreamTrack *)mediaStreamTrack
      statsOutputLevel:(RTCStatsOutputLevel)statsOutputLevel
     completionHandler:
     (nullable void (^)(NSArray<RTCLegacyStatsReport *> *stats))completionHandler;
 
 @end
 
 NS_ASSUME_NONNULL_END