Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2876803002: Do not delete temporary directory if user specified it manually. (Closed)

Created:
3 years, 7 months ago by sakal
Modified:
3 years, 7 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Do not delete temporary directory if user specified it manually. This prevents user from accidentally specifying a directory that contains files that the user wants to keep. BUG=webrtc:7608 NOTRY=True Review-Url: https://codereview.webrtc.org/2876803002 Cr-Commit-Position: refs/heads/master@{#18096} Committed: https://chromium.googlesource.com/external/webrtc/+/27ce02eb06547d041ef016a449a17036528b301a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M webrtc/examples/androidtests/gradle_project_test.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
sakal
PTAL
3 years, 7 months ago (2017-05-11 09:47:48 UTC) #3
kjellander_webrtc
Thanks! lgtm
3 years, 7 months ago (2017-05-11 10:01:50 UTC) #4
kjellander_webrtc
On 2017/05/11 10:01:50, kjellander_webrtc wrote: > Thanks! lgtm ...added NOTRY=True
3 years, 7 months ago (2017-05-11 10:02:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2876803002/1
3 years, 7 months ago (2017-05-11 10:33:30 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 10:36:26 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/27ce02eb06547d041ef016a44...

Powered by Google App Engine
This is Rietveld 408576698