Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2876593003: Fix audio device excessive logging on Windows (Closed)

Created:
3 years, 7 months ago by lliuu
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix audio device excessive logging on Windows In the windows audio device implementation, play block size should be number of samples per 10ms times the number of channels. Meanwhile RequestPlayoutData is expecting number of samples per channel in a block, and we should pass in the per channel number here to avoid debug check. BUG=webrtc:7627 Review-Url: https://codereview.webrtc.org/2876593003 Cr-Commit-Position: refs/heads/master@{#18088} Committed: https://chromium.googlesource.com/external/webrtc/+/c4b126d70e0b0f500e9a2d7f164ed016668ebf54

Patch Set 1 #

Patch Set 2 : fix format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M webrtc/modules/audio_device/win/audio_device_core_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_device/win/audio_device_core_win.cc View 1 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
lliuu
3 years, 7 months ago (2017-05-10 23:57:27 UTC) #5
niklas.enbom
lgtm On 2017/05/10 23:46:56, commit-bot: I haz the power wrote: > Dry run: CQ is ...
3 years, 7 months ago (2017-05-10 23:59:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2876593003/20001
3 years, 7 months ago (2017-05-11 00:05:27 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/c4b126d70e0b0f500e9a2d7f164ed016668ebf54
3 years, 7 months ago (2017-05-11 01:08:30 UTC) #12
henrika_webrtc
lgtm (FYI, modified the BUG link to webrtc:7627 since it points to a Chrome bug ...
3 years, 7 months ago (2017-05-11 08:30:44 UTC) #14
niklas.enbom
3 years, 7 months ago (2017-05-11 13:41:10 UTC) #15
Message was sent while issue was closed.
Henrik, I was agonizing a bit over naming. Do we have any established naming for
multi-channel samples (sometimes called frames)?
On 2017/05/11 08:30:44, henrika_webrtc wrote:
> lgtm (FYI, modified the BUG link to webrtc:7627 since it points to a Chrome
bug
> otherwise)

Powered by Google App Engine
This is Rietveld 408576698