Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2876043002: Disabling orphan headers presubmit check (Closed)

Created:
3 years, 7 months ago by mbonadei
Modified:
3 years, 7 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disabling orphan headers presubmit check It is not working correctly on Windows. I will fix tomorrow morning, but I prefer to disable it so https://codereview.webrtc.org/2823783002 can land. BUG=webrtc:7635 NOTRY=True TBR=kjellander@webrtc.org Review-Url: https://codereview.webrtc.org/2876043002 Cr-Commit-Position: refs/heads/master@{#18106} Committed: https://chromium.googlesource.com/external/webrtc/+/f512c92ab2ee1700da1cf2cd0a7f17d087789c93

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M PRESUBMIT.py View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2876043002/1
3 years, 7 months ago (2017-05-11 19:26:36 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 19:29:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/f512c92ab2ee1700da1cf2cd0...

Powered by Google App Engine
This is Rietveld 408576698